Fix scaling and position of end of line courtesies#32009
Merged
Conversation
mike-spa
approved these changes
Feb 3, 2026
mike-spa
left a comment
mike-spa
left a comment
Contributor
There was a problem hiding this comment.
We have often used a quasi-hack for this of calling the function on tick() - Fraction::eps i.e. one bit before the current tick, which resolves these cases where the tick coincides with the start of next measure. But this is a much better approach.
Contributor
|
Tested on MacOS Tahoe 26.2, Windows 11, Ubuntu 22.04.3. Approved |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 4, 2026
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 4, 2026
Merged
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 20, 2026
4 tasks
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 6, 2026
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 6, 2026
Backport of musescore#32009 Co-Authored-By: James Mizen <26510874+miiizen@users.noreply.github.com>
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 7, 2026
Backport of musescore#32009 Co-Authored-By: James Mizen <26510874+miiizen@users.noreply.github.com>
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 7, 2026
Backport of musescore#32009 Co-Authored-By: James Mizen <26510874+miiizen@users.noreply.github.com>
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 7, 2026
Backport of musescore#32009 Co-Authored-By: James Mizen <26510874+miiizen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #31442
When getting the staff type of items, we should always use the tick at the start of their measure. If we don't,
StaffTypeList::staffTypewill round up to the next bar. Staff type changes can only occur at measure boundaries, so this should be safe.