Skip to content

Fix loading of master & aux output params#33357

Open
RomanPudashkin wants to merge 3 commits into
musescore:mainfrom
RomanPudashkin:fix_master_output_params
Open

Fix loading of master & aux output params#33357
RomanPudashkin wants to merge 3 commits into
musescore:mainfrom
RomanPudashkin:fix_master_output_params

Conversation

@RomanPudashkin
Copy link
Copy Markdown
Contributor

@RomanPudashkin RomanPudashkin commented May 12, 2026

Depends on: musescore/muse_framework#20
Resolves: #33371

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR changes several mixer-related APIs and call sites to stop consuming temporaries: MixerChannelItem::subscribeOnAudioSignalChanges now takes AudioSignalChanges& (lvalue reference) and MixerPanelModel::loadOutputParams now takes const AudioOutputParams&. Corresponding std::move() calls were removed across setupConnections and channel builder callbacks. addBlankSlots now passes params by value into buildOutputResourceItem. The muse submodule pointer and the file copyright year were updated.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The PR description is minimal and lacks required sections from the template such as motivation, detailed problem description, and completion of mandatory checklists. Expand the description to explain the problem being fixed, the motivation for changes, and complete all checklist items from the template.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix loading of master & aux output params' directly corresponds to the main changes: parameter signature updates and removal of std::move calls in master and auxiliary channel output parameter loading.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RomanPudashkin RomanPudashkin force-pushed the fix_master_output_params branch 2 times, most recently from af5854e to 4a914e5 Compare May 12, 2026 10:35
@RomanPudashkin RomanPudashkin force-pushed the fix_master_output_params branch from 4a914e5 to b43326e Compare May 12, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No sound during playback after loading Audio FX plugin (5.0 nightly master)

1 participant