Fix FxChain setup#20
Open
RomanPudashkin wants to merge 1 commit into
Open
Conversation
igorkorsukov
approved these changes
May 12, 2026
1. avoid assigning the first FX node as the chain input so the mixer can be used as the input at a higher level 2. fix FX processing order in the chain 3. avoid repeated rebuild() calls during chain construction
RomanPudashkin
force-pushed
the
fix_fx_chain
branch
from
7561ae8 to
27625cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: musescore/MuseScore#33371