Bump MF submodule (ce5bcfa)#33374
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
📝 WalkthroughWalkthroughThis PR updates the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@muse`:
- Line 1: The submodule pointer in the muse submodule references a non-existent
commit (ce5bcfa1b58a2e96a3323deacab3724c26b28cb9); to fix, open the muse
submodule repository, fetch the latest refs from its remote, locate the correct
commit or tag that contains the Windows Explorer file selection fix, checkout
that valid commit, then update the superproject's submodule pointer to that
commit and commit the change in the parent repo (ensure the
.gitmodules/reference is consistent and push both submodule and parent repo
updates).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| @@ -1 +1 @@ | |||
| Subproject commit 8d6707fb9cbc9b5b52f7b7649d0dd4976dd4e0ac | |||
| Subproject commit ce5bcfa1b58a2e96a3323deacab3724c26b28cb9 | |||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify muse submodule commit and check for the Windows Explorer fix
# Navigate to muse submodule
cd muse || exit 1
# Verify the commit exists
echo "=== Checking if commit ce5bcfa1b58a2e96a3323deacab3724c26b28cb9 exists ==="
git cat-file -t ce5bcfa1b58a2e96a3323deacab3724c26b28cb9 2>/dev/null || echo "ERROR: Commit does not exist"
# Get the commit message and details
echo -e "\n=== Commit details ==="
git log -1 --format="%H%n%an <%ae>%n%ad%n%s%n%b" ce5bcfa1b58a2e96a3323deacab3724c26b28cb9
# Search for changes related to PlatformInteractive or revealInFileBrowser
echo -e "\n=== Files changed in this commit ==="
git diff-tree --no-commit-id --name-only -r ce5bcfa1b58a2e96a3323deacab3724c26b28cb9
# Look for relevant code changes
echo -e "\n=== Searching for revealInFileBrowser changes ==="
git show ce5bcfa1b58a2e96a3323deacab3724c26b28cb9 | grep -A 5 -B 5 "revealInFileBrowser\|explorer.exe" || echo "No matches found in this commit"
# Check the range of changes if old commit is available
echo -e "\n=== Checking for previous commit reference ==="
cd .. && git diff HEAD~1 HEAD -- muse | grep "^-Subproject" | gawk '{print $3}'Repository: musescore/MuseScore
Length of output: 923
Reject: The submodule commit does not exist.
The commit ce5bcfa1b58a2e96a3323deacab3724c26b28cb9 does not exist in the muse submodule repository. Git returns "remote error: upload-pack: not our ref", indicating this is an invalid commit hash. This will cause build failures when attempting to clone or update the submodule. Verify the correct commit hash for the Windows Explorer file selection fix and update the submodule pointer.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@muse` at line 1, The submodule pointer in the muse submodule references a
non-existent commit (ce5bcfa1b58a2e96a3323deacab3724c26b28cb9); to fix, open the
muse submodule repository, fetch the latest refs from its remote, locate the
correct commit or tag that contains the Windows Explorer file selection fix,
checkout that valid commit, then update the superproject's submodule pointer to
that commit and commit the change in the parent repo (ensure the
.gitmodules/reference is consistent and push both submodule and parent repo
updates).
2 participants
Resolves: #33319 (there are only MF changes for it)
First time updating the MF submodule, and first opportunity to screw things up since the NEW WAY. :)