Skip to content

Delete the code that removes the main window transparency#33393

Open
krasko78 wants to merge 1 commit into
musescore:mainfrom
krasko78:32612-DeleteCodeThatRemovesMainWindowTransparency
Open

Delete the code that removes the main window transparency#33393
krasko78 wants to merge 1 commit into
musescore:mainfrom
krasko78:32612-DeleteCodeThatRemovesMainWindowTransparency

Conversation

@krasko78
Copy link
Copy Markdown
Contributor

Resolves: #32612
Resolves: #31620
Need to retest #29630

Replaces MuseScore/PR32940.

In MF/PR15 we stopped making the main window transparent on startup. Those changes were consumed into MSS in MuseScore/PR33374 (at that moment there was a check that was forcing the MF submodule to always point at the latest commit). This PR deletes the code that removes the transparency on the main window once it has loaded as it is not longer needed.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7038ff45-7fc2-413e-a5db-90e9d8698524

📥 Commits

Reviewing files that changed from the base of the PR and between 98e96cb and c68b689.

📒 Files selected for processing (1)
  • src/appshell/qml/MuseScore/AppShell/WindowContent.qml
💤 Files with no reviewable changes (1)
  • src/appshell/qml/MuseScore/AppShell/WindowContent.qml

📝 Walkthrough

Walkthrough

The PR removes a single line from the onPageLoaded handler in WindowContent.qml. The handler previously set window.opacity to 1.0 when a page finished loading; this opacity assignment is now deleted. The handler retains the console log statement and the call to interactiveProvider.onPageOpened().

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing code that sets window opacity to 1.0 after the startup page loads.
Description check ✅ Passed The PR description is comprehensive, includes required sections, references linked issues, explains the motivation, and confirms all checklist items with appropriate reasoning.
Linked Issues check ✅ Passed The PR directly addresses the root cause identified in both linked issues by removing the transparency-clearing code that was causing UI problems on startup.
Out of Scope Changes check ✅ Passed All changes are directly scoped to the stated objectives: removing the transparency-clearing code is the singular, focused change required.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RomanPudashkin
Copy link
Copy Markdown
Contributor

@krasko78 please rebase

@krasko78 krasko78 force-pushed the 32612-DeleteCodeThatRemovesMainWindowTransparency branch from 98e96cb to c68b689 Compare May 15, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants