[4.7.3] Fix #33536: shorten checkCloudIsAvailable timeout

[RomanPudashkin]

Resolves: #33536

[claude]

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

[RomanPudashkin]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 36698177-db94-458f-9579-7990384d5995

📥 Commits

Reviewing files that changed from the base of the PR and between a538173 and 3d4616e.

📒 Files selected for processing (2)

• src/framework/cloud/internal/abstractcloudservice.cpp
• src/project/internal/projectactionscontroller.cpp

---

📝 Walkthrough

Walkthrough

This PR introduces two robustness improvements. First, the cloud availability check in AbstractCloudService now enforces a 5-second timeout on the HTTP request using a QEventLoop and QTimer, ensuring the operation does not hang indefinitely. If the timeout fires, the request is canceled before the loop exits. Second, ProjectActionsController::closeOpenedProject() now includes a guard that prevents project closure when a save or upload operation is already in progress, returning false to block the close sequence.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The PR description includes the issue reference but lacks key sections from the template such as change motivation, commit message details, and verification checklist items.	Expand the description to include motivation for the changes, confirmation of coding standards compliance, and details about testing and code compilation verification.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: shortening the checkCloudIsAvailable timeout to fix issue #33536, which addresses the UI freeze when cloud connectivity is lost.
Linked Issues check	✅ Passed	The code changes directly address the issue: the timeout reduction in checkCloudIsAvailable prevents prolonged UI freeze, and the close-during-save guard prevents crashes when attempting to close during background operations.
Out of Scope Changes check	✅ Passed	Both changes are directly scoped to resolving issue #33536: reducing cloud availability timeout and preventing project close during save/upload operations.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[davidstephengrant]

@RomanPudashkin Tested and approved on Windows 11 and Ubuntu 24.04.4 LTS.