Fix #33536: reject close during checkCloudIsAvailable

[RomanPudashkin]

Ports: #33543
Resolves: #33536
Depends on: musescore/muse_framework#58

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 51ef7f86-375e-492a-8374-e8c26679ae84

📥 Commits

Reviewing files that changed from the base of the PR and between 68627a3 and b775a92.

📒 Files selected for processing (1)

• src/project/internal/projectactionscontroller.cpp

---

📝 Walkthrough

Walkthrough

This PR adds a safety guard to ProjectActionsController::closeOpenedProject that prevents the project from being closed while a save or cloud upload operation is in progress. The method now checks m_isProjectSaving and m_isProjectUploading flags and returns false early if either is active, ensuring these critical background operations complete before allowing project closure.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The PR description provides linked issue and PR references, but lacks the detailed checklist items and motivation explanation required by the template.	Complete the PR description template by filling in the checklist items (CLA signature, title confirmation, commit messages, testing, code guidelines compliance) and adding explicit motivation for the changes.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title references issue #33536 and describes the key change: rejecting close events during cloud availability checks, which directly addresses the crash/freeze issue.
Linked Issues check	✅ Passed	The code change prevents project closure during save/upload operations, directly addressing issue #33536's freeze/crash when network is lost during cloud operations.
Out of Scope Changes check	✅ Passed	The 4-line change adds an early return guard condition to reject close events during cloud operations, which is within scope and directly addresses the reported freeze/crash issue.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}