Skip to content

Add notehead schemes for pitch names without alterations#34151

Merged
ajuncosa merged 1 commit into
musescore:mainfrom
ajuncosa:notehead-schemes
Jul 16, 2026
Merged

Add notehead schemes for pitch names without alterations#34151
ajuncosa merged 1 commit into
musescore:mainfrom
ajuncosa:notehead-schemes

Conversation

@ajuncosa

Copy link
Copy Markdown
Contributor

Resolves: #34149

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 97116b1d-886b-42e3-9cf6-ef3d18abf618

📥 Commits

Reviewing files that changed from the base of the PR and between 7d60b65 and b0f0202.

📒 Files selected for processing (7)
  • src/engraving/dom/note.cpp
  • src/engraving/dom/note.h
  • src/engraving/types/types.h
  • src/engraving/types/typesconv.cpp
  • src/notationscene/widgets/editstafftype.cpp
  • src/propertiespanel/qml/MuseScore/PropertiesPanel/notation/notes/noteheads/noteheadsettingsmodel.cpp
  • src/propertiespanel/qml/MuseScore/PropertiesPanel/notation/stafftype/StaffTypeSettings.qml
🚧 Files skipped from review as they are similar to previous changes (6)
  • src/propertiespanel/qml/MuseScore/PropertiesPanel/notation/stafftype/StaffTypeSettings.qml
  • src/propertiespanel/qml/MuseScore/PropertiesPanel/notation/notes/noteheads/noteheadsettingsmodel.cpp
  • src/engraving/types/types.h
  • src/notationscene/widgets/editstafftype.cpp
  • src/engraving/dom/note.h
  • src/engraving/dom/note.cpp

📝 Walkthrough

Walkthrough

Adds generic and German pitch-name notehead schemes that omit accidentals. The enum, conversion mappings, staff-type selectors, and properties-panel dropdowns expose the new variants. Notehead rendering now handles German and no-accidentals schemes through shared selection logic, including tpc-based natural, sharp, and flat mappings. The note-name predicate includes all pitch-name scheme variants, and the headScheme property documentation reflects the expanded option set.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only references the issue and omits the required summary, motivation, checklist items, and testing details. Expand the PR description to follow the template: add a short change summary, motivation, completed checklist items, and testing/verification details.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: adding notehead schemes for unaltered pitch names.
Linked Issues check ✅ Passed The changes add the new schemes, wire them into selection/UI lists, and update rendering so unaltered pitch names are shown as requested.
Out of Scope Changes check ✅ Passed The modified files are all directly related to implementing and exposing the new notehead schemes, with no clear unrelated changes.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ajuncosa
ajuncosa requested review from RomanPudashkin and miiizen and removed request for RomanPudashkin July 10, 2026 16:00
@davidstephengrant

Copy link
Copy Markdown
Contributor

@ajuncosa Tested and approved on macOS 26.5.2.

@ajuncosa
ajuncosa merged commit 4d3e04e into musescore:main Jul 16, 2026
14 checks passed
@ajuncosa
ajuncosa deleted the notehead-schemes branch July 16, 2026 15:57
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 16, 2026
Backport of musescore#34151

Co-Authored-By: Ana <59970392+ajuncosa@users.noreply.github.com>
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 17, 2026
Backport of musescore#34151

Co-Authored-By: Ana <59970392+ajuncosa@users.noreply.github.com>
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 17, 2026
Backport of musescore#34151

Co-Authored-By: Ana <59970392+ajuncosa@users.noreply.github.com>
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 17, 2026
Backport of musescore#34151

Co-Authored-By: Ana <59970392+ajuncosa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add notehead schemes for pitch names without alterations

3 participants