Skip to content

Add new accent colours and replace legacy ones#109

Open
ajuncosa wants to merge 1 commit into
musescore:mainfrom
ajuncosa:accent-colours
Open

Add new accent colours and replace legacy ones#109
ajuncosa wants to merge 1 commit into
musescore:mainfrom
ajuncosa:accent-colours

Conversation

@ajuncosa

@ajuncosa ajuncosa commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Resolves: #33863

Related to: musescore/MuseScore#33974

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: d83fba43-963b-40d2-bcfe-aa4be728f1f4

📥 Commits

Reviewing files that changed from the base of the PR and between 85afcbe and e0c49b9.

📒 Files selected for processing (1)
  • framework/ui/internal/uiconfiguration.cpp

📝 Walkthrough

Walkthrough

UiConfiguration::possibleAccentColors() updates the hardcoded accent palettes for both light and dark modes. The light palette is replaced with a new hex color set, and the dark palette is replaced with a larger new hex color set. The mode-based selection logic remains unchanged.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only references the issue and related PR, and omits the required summary, motivation, and checklist sections. Add a short change summary and motivation, then complete the required checklist items from the template, including CLA, testing, and commit notes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: adding new accent colours and replacing legacy ones.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more accent colours in Preferences

1 participant