Skip to content

Add MPE support for East Asian instruments #124

Merged
RomanPudashkin merged 2 commits into
musescore:mainfrom
RomanPudashkin:mpe_new_instruments
Jul 2, 2026
Merged

Add MPE support for East Asian instruments #124
RomanPudashkin merged 2 commits into
musescore:mainfrom
RomanPudashkin:mpe_new_instruments

Conversation

@RomanPudashkin

Copy link
Copy Markdown
Contributor

Ports (changes in the framework): musescore/MuseScore#33834
Also ports (1st commit): musescore/MuseScore#34037

Added instruments:
- China: Guqin, Pipa, Yangqin
- Japan: Hichiriki, Sho
- Korea (melodic): Ajaeng, Daegeum, Gayageum
- Korea (percussion): Samul Buk, Samul Janggu, Sanjo Janggu, Sori Buk

Also fix typos in Guzheng and Baryton IDs
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@RomanPudashkin, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 28 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ad34f716-1c22-4291-b6af-c14063b78b77

📥 Commits

Reviewing files that changed from the base of the PR and between 1418006 and fdb5cdc.

📒 Files selected for processing (4)
  • framework/audio/engine/internal/synthesizers/fluidsynth/soundmapping.h
  • framework/mpe/soundid.h
  • framework/musesampler/internal/apitypes.h
  • framework/musesampler/internal/musesamplersequencer.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@RomanPudashkin RomanPudashkin merged commit a068704 into musescore:main Jul 2, 2026
3 checks passed
@RomanPudashkin RomanPudashkin deleted the mpe_new_instruments branch July 2, 2026 15:11
@RomanPudashkin RomanPudashkin restored the mpe_new_instruments branch July 3, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant