Allow configuring Snapcast TCP stream sample rate and bit depth - #5140
Merged
OzGav merged 5 commits intoAug 8, 2026
Merged
Conversation
Contributor
|
Please restore the PR description template, only select one type of change and CI is failing. |
Contributor
|
✅ The title and description are good to go. Thanks! |
rwjack
force-pushed
the
feature/snapcast-configurable-stream-format
branch
from
July 31, 2026 07:19
83cd28e to
643d920
Compare
MarvinSchenkel
approved these changes
Aug 3, 2026
MarvinSchenkel
marked this pull request as draft
August 3, 2026 13:17
rwjack
marked this pull request as ready for review
August 5, 2026 15:33
Contributor
Author
|
Hey Marvin, thanks for the review. I made some changes based on your comments. Lmk what you think |
Enables optional hi-res PCM (up to 192 kHz / 24-bit) for Music Assistant Snapcast sources, adding packed_s24le for 24-bit ffmpeg ingest pending snapcast/snapcast#1532.
The new Snapcast config entry strings were missing from the generated en.json source file, which failed the build_translations_source hook.
Built-in Snapserver stays at 48 kHz / 16-bit until upstream packed 24-bit ingest lands; hide the sample rate and bit depth options unless Use existing Snapserver is enabled.
Use provider.stream_audio_format directly, simplify external stream format casting, and refuse to adopt orphan streams whose sample format no longer matches.
rwjack
force-pushed
the
feature/snapcast-configurable-stream-format
branch
from
August 5, 2026 15:42
ed89c56 to
187daf4
Compare
rwjack
added a commit
to rwjack/music-assistant-io
that referenced
this pull request
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Makes the sample rate and bit depth of the Music Assistant -> Snapserver TCP source
configurable via two new advanced provider settings, instead of being hardcoded to
48000:16:2. Defaults are unchanged (48 kHz / 16-bit).
For 24-bit the stream is sent as packed
s24leand the TCP source URI getspacked_s24le=true, which requires a Snapserver build withsnapcast/snapcast#1532.
Related issue (if applicable):
Types of changes
bugfixnew-featureenhancementnew-providerbreaking-changerefactordocumentationmaintenancecidependenciesChecklist
pre-commit run --all-filespasses.pytestpasses, and tests have been added/updated undertests/where applicable.music-assistant/modelsis linked.music-assistant/frontendis linked.