Migration for new icons for picker - #5306
Merged
Merged
Conversation
Contributor
|
✅ The title and description are good to go. Thanks! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates player icon handling to use the Music Assistant shared icon set, including a config migration to rewrite legacy stored icon values (old picker ids and mdi-* values) into canonical shared-icon-set ids and aligning defaults and UI strings accordingly.
Changes:
- Add a config migration that maps legacy player icon values to canonical shared-icon-set ids (dropping unmappable
mdi-*selections to fall back to defaults). - Update player icon defaults and runtime fallback behavior to ensure a valid icon id is always served.
- Update the icon description strings to point users to the shared-icons repository, and add unit tests for the migration.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/controllers/config/test_migrations.py | Adds test coverage for the new player icon migration behavior (rewrite, drop, noop, idempotency, malformed input). |
| music_assistant/translations/en.json | Updates the icon config entry description to reference the shared Music Assistant icon set. |
| music_assistant/strings.json | Updates the source string for the icon config entry description (basis for translations). |
| music_assistant/models/player.py | Ensures players without an icon config entry return the configured icon or the config entry default. |
| music_assistant/controllers/config/migrations.py | Implements _migrate_player_icons and wires it into the overall config migration flow. |
| music_assistant/constants.py | Bumps API schema version and changes default player/group icon ids to shared-icon-set ids. |
chrisuthe
approved these changes
Aug 4, 2026
Member
|
LGTM! |
chrisuthe
enabled auto-merge
August 4, 2026 15:09
chrisuthe
force-pushed
the
icon-migration
branch
from
August 4, 2026 15:57
8d30468 to
232e571
Compare
chrisuthe
added this pull request to the merge queue
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Related issue (if applicable):
Types of changes
bugfixnew-featureenhancementnew-providerbreaking-changerefactordocumentationmaintenancecidependenciesChecklist
pre-commit run --all-filespasses.pytestpasses, and tests have been added/updated undertests/where applicable.music-assistant/modelsis linked.music-assistant/frontendis linked.