Fix dependency auto-merge workflow env contract test - #5507
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the dependency auto-merge workflow contract test to reflect the expanded workflow env (added for the refresh-stale GitHub App token job) and to ensure the new identity fields remain enforced.
Changes:
- Extend the expected top-level
envmapping intest_dependency_auto_merge_enforces_app_bot_identity_contractto includeEXPECTED_APP_SLUGandEXPECTED_APP_INSTALLATION_ID. - Add assertions that the
refresh-stalejob’sVerify GitHub App identitystep checks both the app slug and installation id.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
MarvinSchenkel
marked this pull request as ready for review
August 8, 2026 11:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
#5499 added a
refresh-stalejob that mints a GitHub App token, soauto-merge-dependency-updates.ymlgainedEXPECTED_APP_SLUGandEXPECTED_APP_INSTALLATION_IDin its top-levelenv.test_dependency_auto_merge_enforces_app_bot_identity_contractasserts thatenvmapping exactly and still listed only the three bot-login constants, sodevis red.That assert is the first one in the test, so every later assertion in the
function was skipped in CI as well.
Changes
envmapping.Verify GitHub App identitystep ofrefresh-stalecomparesagainst both, so the new constants stay covered instead of only declared.
Related issue (if applicable):
Types of changes
bugfixnew-featureenhancementnew-providerbreaking-changerefactordocumentationmaintenancecidependenciesChecklist
pre-commit run --all-filespasses.pytestpasses, and tests have been added/updated undertests/where applicable.music-assistant/modelsis linked.music-assistant/frontendis linked.