Skip to content

Fix dependency auto-merge workflow env contract test - #5507

Merged
MarvinSchenkel merged 2 commits into
devfrom
fix/dependency-auto-merge-env-contract
Aug 8, 2026
Merged

Fix dependency auto-merge workflow env contract test#5507
MarvinSchenkel merged 2 commits into
devfrom
fix/dependency-auto-merge-env-contract

Conversation

@MarvinSchenkel

Copy link
Copy Markdown
Contributor

What does this implement/fix?

#5499 added a refresh-stale job that mints a GitHub App token, so
auto-merge-dependency-updates.yml gained EXPECTED_APP_SLUG and
EXPECTED_APP_INSTALLATION_ID in its top-level env.
test_dependency_auto_merge_enforces_app_bot_identity_contract asserts that
env mapping exactly and still listed only the three bot-login constants, so
dev is red.

That assert is the first one in the test, so every later assertion in the
function was skipped in CI as well.

Changes

  • Add both constants to the expected env mapping.
  • Assert that the Verify GitHub App identity step of refresh-stale compares
    against both, so the new constants stay covered instead of only declared.

Related issue (if applicable):

  • related issue

Types of changes

  • Bugfix (non-breaking change which fixes an issue) — bugfix
  • New feature (non-breaking change which adds functionality) — new-feature
  • Enhancement to an existing feature — enhancement
  • New music/player/metadata/plugin provider — new-provider
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) — breaking-change
  • Refactor (no behaviour change) — refactor
  • Documentation only — documentation
  • Maintenance / chore — maintenance
  • CI / workflow change — ci
  • Dependencies bump — dependencies

Checklist

  • The code change is tested and works locally.
  • pre-commit run --all-files passes.
  • pytest passes, and tests have been added/updated under tests/ where applicable.
  • For changes to shared models, the companion PR in music-assistant/models is linked.
  • For changes affecting the UI, the companion PR in music-assistant/frontend is linked.
  • I have read and complied with the project's AI Policy for any AI-assisted contributions.
  • I have raised a PR against the documentation repository targeting the main or beta branch as appropriate.

Copilot AI lite review requested due to automatic review settings August 8, 2026 11:14
@github-actions github-actions Bot added the ci label Aug 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the dependency auto-merge workflow contract test to reflect the expanded workflow env (added for the refresh-stale GitHub App token job) and to ensure the new identity fields remain enforced.

Changes:

  • Extend the expected top-level env mapping in test_dependency_auto_merge_enforces_app_bot_identity_contract to include EXPECTED_APP_SLUG and EXPECTED_APP_INSTALLATION_ID.
  • Add assertions that the refresh-stale job’s Verify GitHub App identity step checks both the app slug and installation id.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@MarvinSchenkel
MarvinSchenkel marked this pull request as ready for review August 8, 2026 11:16
@MarvinSchenkel
MarvinSchenkel merged commit d36fc61 into dev Aug 8, 2026
17 checks passed
@MarvinSchenkel
MarvinSchenkel deleted the fix/dependency-auto-merge-env-contract branch August 8, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants