Updated docker build script - #84
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the GitHub Actions publish workflow that builds and publishes multi-arch Docker images to GHCR, consolidating image naming/tagging under a single DOCKER_REPO env var and simplifying the build→manifest flow.
Changes:
- Removes the separate “var” job and centralizes the image repository as
env.DOCKER_REPO. - Exposes the computed image version tag from the
buildjob for downstream consumption. - Streamlines manifest creation to publish both the version tag and
latestconsistently using the same repo/tag scheme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the GitHub Actions workflow for building and publishing Docker images. The main improvements focus on simplifying variable management, enhancing consistency with environment variables, and streamlining the build and manifest creation process.
Workflow and Variable Management:
varjob and replaced custom variable passing with a centralizedDOCKER_REPOenvironment variable, simplifying workflow logic and improving maintainability.buildjob, eliminating unnecessary complexity in job chaining.Build and Manifest Process:
"latest"for Docker image tagging, ensuring both tags are created reliably.BUILDKIT_PROGRESS=plainfor improved logging and to output the Docker image tag for downstream jobs.DOCKER_REPOenvironment variable, aligning image references and making the workflow more robust.