Feat/mux video grab bag#9
Merged
Merged
Conversation
cjpillsbury
added
enhancement
dylanjha
reviewed
Aug 19, 2021
dylanjha
left a comment
dylanjha
left a comment
Contributor
There was a problem hiding this comment.
Just a few code nit-picks -- overall looks great though
| metadata-video-id="This is a more different ID" | ||
| metadata-video-title="IM NOT STARWARS YOURE STARWARS" | ||
| metadata-viewer-user-id="...starwars" | ||
| prefer-native |
cjpillsbury
force-pushed
the
feat/mux-video-grab-bag
branch
from
August 19, 2021 17:26
f43ae67 to
d821ec5
Compare
luwes
added a commit
that referenced
this pull request
May 6, 2025
* fix: mux-video-ads set up immediately * fix: mse / native check + add Mux data ads * feat: add mux-data-keep-session + fix iOS ads native playback
luwes
added a commit
that referenced
this pull request
May 7, 2025
* fix: mux-video-ads set up immediately * fix: mse / native check + add Mux data ads * feat: add mux-data-keep-session + fix iOS ads native playback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
player_versionmux metadata based on the currentpackage.jsonversion #8playback-id#7video_idfor mux data based onplayback_id#6