Skip to content

Invalid non-blank line in synaptic.desktop.in#246

Merged
mvo5 merged 1 commit into
mvo5:masterfrom
amaa-99:129-invalid-non-blank-line-in-synapticdesktopin
Jul 16, 2026
Merged

Invalid non-blank line in synaptic.desktop.in#246
mvo5 merged 1 commit into
mvo5:masterfrom
amaa-99:129-invalid-non-blank-line-in-synapticdesktopin

Conversation

@amaa-99

@amaa-99 amaa-99 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Removed the leading '_' from the Name, GenericName and Comment entries.
(closes amaa-99#129)

@amaa-99

amaa-99 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

This fixes the msgfmt errors:
msgfmt --desktop --template=data/synaptic.desktop.in -o synaptic.desktop -d po -v

@amaa-99

amaa-99 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

p.s. Eventually for a separate pull:

msgfmt --desktop --template=../data/synaptic.desktop.in -o synaptic.desktop -d ../po -v --check

lists a lot of errors in the .po files:

...
../po/no.po:2080: number of format specifications in 'msgid_plural' and 'msgstr[0]' does not match
../po/no.po:2196: number of format specifications in 'msgid' and 'msgstr' does not match
msgfmt: found 10 fatal errors
../po/pa.po:7: warning: header field 'Last-Translator' still has the initial default value
../po/ps.po:7: warning: header field 'Last-Translator' still has the initial default value
../po/pt.po:7: warning: header field 'Last-Translator' still has the initial default value
../po/pt.po:1280: number of format specifications in 'msgid' and 'msgstr' does not match
msgfmt: found 1 fatal error
../po/pt_PT.po:7: warning: header field 'Last-Translator' still has the initial default value
../po/pt_PT.po:7: warning: header field 'Language' still has the initial default value
...

@amaa-99

amaa-99 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

We could eventually enable the checks in the build file once those errors/warnings are under control, e.g.:

i18n.merge_file(
  input: 'synaptic.desktop.in',
  output: 'synaptic.desktop',
  po_dir: join_paths(meson.project_source_root(), 'po'),
  type: 'desktop',
  install: true,
  install_dir: join_paths(get_option('datadir'), 'applications'),
  args: ['-c', '-v'],
)

@amaa-99
amaa-99 force-pushed the 129-invalid-non-blank-line-in-synapticdesktopin branch 2 times, most recently from dd079c8 to 1cfdde6 Compare July 14, 2026 13:19
Removed the leading '_' from the Name, GenericName and Comment entries.
@amaa-99
amaa-99 force-pushed the 129-invalid-non-blank-line-in-synapticdesktopin branch from 1cfdde6 to f613c36 Compare July 15, 2026 10:53

@mvo5 mvo5 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@mvo5
mvo5 merged commit 4e7668f into mvo5:master Jul 16, 2026
2 checks passed
@AsciiWolf

AsciiWolf commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

What, why? The "_" prefixed lines are replaced with the translated ones by gettext. Same with the AppStream metainfo file. These are .in suffixed desktop files, you are not supposed to validate or install them directly.

@mvo5 This change should be reverted. Thanks!

@AsciiWolf

Copy link
Copy Markdown
Contributor

#263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid non-blank line in synaptic.desktop.in

3 participants