Repository navigation
Addresses the two newest pygaposa-related review comments on the Home Assistant integration PR (home-assistant/core#161442).
Security
- Do not log Firebase request URLs verbatim.
FirebaseAuth.sign_in,FirebaseAuth.refresh_id_tokenandFirestore._getpreviously logged the rawClientResponseat debug level; the sign-in and token-refresh URLs include?key=<api key>, so enabling debug logging leaked the configured Firebase API key. These now log only the method, query-stripped URL and status.
Fixed
- Make polling cancellation-safe. When a caller of
Device.update()/PollManager.wait_for_condition()is cancelled (e.g. an outer timeout expires), the waiter is now removed and the detached background polling task is cancelled when it was the last waiter. Previously the poll continued in the background and could later notify listeners with stale data after the caller had given up.