Skip to content

Confirm resumed thread subscriptions#2

Merged
mwolson merged 1 commit into
mwolson:ios-fixes-mainfrom
twistedgrim:codex/thread-sync-synchronized-marker
Jul 13, 2026
Merged

Confirm resumed thread subscriptions#2
mwolson merged 1 commit into
mwolson:ios-fixes-mainfrom
twistedgrim:codex/thread-sync-synchronized-marker

Conversation

@twistedgrim

@twistedgrim twistedgrim commented Jul 13, 2026

Copy link
Copy Markdown

Summary

  • Add a synchronized stream item after a resumed thread subscription has attached its live buffer.
  • Keep a warm cached thread synchronizing through reconnect until that item arrives.

Reproduction

  1. Start with a cached thread detail snapshot and its persisted snapshot sequence.
  2. Reconnect and subscribe using the cached sequence as the after-sequence cursor.
  3. Make the server replay empty because the cache is already current.

Before this change, the client could only infer completion from the transport state; no stream frame proved that catch-up and the live buffer were attached. This PR makes that boundary explicit. The server test exercises the empty-replay case, and the client-state test verifies that a cached thread stays synchronizing until the confirmation arrives.

Validation

  • vp test apps/server/src/server.test.ts packages/client-runtime/src/state/threads-sync.test.ts
  • vp check
  • vp run typecheck

@github-actions github-actions Bot added size:S vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Jul 13, 2026
@mwolson mwolson marked this pull request as ready for review July 13, 2026 21:05
@mwolson mwolson merged commit 4311beb into mwolson:ios-fixes-main Jul 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants