Centralize process execution lifecycle - #6
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR centralizes subprocess execution responsibilities (spawning, output capture, timeouts, process-group cleanup) into a single ProcessExecution utility, and updates shell PATH probing and tests to use the shared implementation.
Changes:
- Introduces
ProcessExecutionto own process lifecycle concerns previously spread acrossCommandRunner,ShellEnvironment, andProcessGroup. - Refactors
SystemCommandRunnerandShellEnvironmentto delegate toProcessExecutionhelpers. - Relocates/updates tests to validate bounded tail-reading via the new shared implementation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Tests/PMMCoreTests/ShellEnvironmentTests.swift | Removes tests tied to now-centralized helpers. |
| Tests/PMMCoreTests/CommandRunnerTests.swift | Adds a bounded tail-read test using ProcessExecution.readTail. |
| Sources/PMMCore/ShellEnvironment.swift | Switches PATH probe execution to ProcessExecution.runBounded. |
| Sources/PMMCore/ProcessGroup.swift | Removes standalone process-group implementation now embedded in ProcessExecution. |
| Sources/PMMCore/ProcessExecution.swift | New centralized implementation for process execution, capture, and cleanup. |
| Sources/PMMCore/CommandRunner.swift | Simplifies SystemCommandRunner to delegate to ProcessExecution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.