[ISSUE #8088]♻️Enforce unified subscriber bootstrap ownership

[mxsm]

Which Issue(s) This PR Fixes(Closes)

• Fixes [Refactor♻️] Enforce unified subscriber bootstrap ownership #8088

Brief Description

This PR strengthens the observability architecture guard that protects global tracing subscriber ownership.

Changes include:

• Route subscriber installation checks through a dedicated detector.
• Continue detecting direct tracing_subscriber::fmt(), tracing_subscriber::registry(), and set_global_default usage.
• Detect imported SubscriberInitExt call chains that invoke .init() or .try_init().
• Add detector tests for direct initialization, imported initialization, and unrelated business init() calls.
• Clarify allowlist comments for the unified bootstrap owner and remaining compatibility paths.

How Did You Test This Change?

• cargo test -p rocketmq-observability --test architecture_guards passed.
• cargo fmt --all passed.
• cargo test -p rocketmq-observability --test architecture_guards --all-features passed.
• cargo clippy --workspace --no-deps --all-targets --all-features -- -D warnings passed.

Summary by CodeRabbit

• Bug Fixes
  • Improved detection of tracing subscriber setup in automated checks, reducing the chance of missing valid installation patterns.
  • Expanded test coverage for common initialization styles and unrelated init calls, making validation more reliable.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 057f9ff5-b511-4222-a9c1-64eae0b47bcd

📥 Commits

Reviewing files that changed from the base of the PR and between e51705b and d53e817.

📒 Files selected for processing (1)

• rocketmq-observability/tests/architecture_guards.rs

---

Walkthrough

Modifies rocketmq-observability's architecture guard test to use a new has_subscriber_installation detector, replacing a fixed pattern-list scan. Adds subscriber_init_statement_installs_global_subscriber helper to detect statement-level .init()/.try_init() chains tied to tracing_subscriber, plus new unit tests and allowlist comments.

Changes

Subscriber Installation Detector Update

Layer / File(s)	Summary
Detection helper functions rocketmq-observability/tests/architecture_guards.rs	Adds has_subscriber_installation combining direct pattern matching, set_global_default(...) detection, and statement-level analysis via subscriber_init_statement_installs_global_subscriber for .init(/.try_init( chains tied to tracing_subscriber, fmt(), registry(), or SubscriberInitExt.
Guard test wiring and allowlist comments rocketmq-observability/tests/architecture_guards.rs	Changes subscriber_installation_sites_are_tracked to delegate to has_subscriber_installation(source) instead of scanning SUBSCRIBER_INSTALL_PATTERNS directly; adds inline comments to SUBSCRIBER_INSTALL_ALLOWLIST entries.
Detector unit tests rocketmq-observability/tests/architecture_guards.rs	Adds tests covering direct tracing_subscriber::fmt().init(), imported SubscriberInitExt-based try_init(), and confirming unrelated init calls (e.g. store init) are not flagged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

• [Test🧪] Track observability subscriber installation coverage #8066: Improves tracking of subscriber installation sites in architecture_guards.rs, matching this issue's test coverage objective.
• [Refactor♻️] Add unified telemetry logging bootstrap #8080: Enhances subscriber-installation detection logic tied to unified telemetry bootstrap guard tracking.

Poem

A rabbit sniffs through code with glee,
hunting .init() where'er it be,
no fmt() or registry() can hide,
nor try_init() on the sneaky side.
Allowlist notes now clear and neat—
hop hop, another guard complete! 🐇

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch mxsm/subscriber-bootstrap-architecture-guard

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[rocketmq-rust-bot]

🔊@mxsm 🚀Thanks for your contribution🎉！

💡CodeRabbit(AI) will review your code first🔥！

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.