fix: xen deactivation fatals on a use-before-assign - #2
Merged
Conversation
$serviceClass was read one line before it was assigned, so on PHP 8 every deactivation of XEN_LINUX / XEN_WINDOWS raised a fatal Error before reaching the history write. Deactivation cannot have been working. Found by the shared contract harness (S-1), which executes the handler rather than reflecting over it -- the reflection-only assertions this repo had before passed the whole time, because the method existed, was public, was static and took one argument. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getDeactivate()read$serviceClassone line before assigning it:On PHP 8 that is a fatal
Error, so deactivatingXEN_LINUX/XEN_WINDOWShas not been working. One-line reorder.Found by the shared contract harness (assertion S-1), which executes the handler. This repo's pre-existing reflection assertions passed throughout — the method existed, was public, was static, took one argument, and fataled the moment it ran.
Suite green: 81 tests, 13 skipped, 0 failures.
🤖 Generated with Claude Code