perf: avoid repeated line feature work in Flash PDF - #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Native inline-script matching recomputes font-size medians for every candidate pair, and ordinary lines compute structural script evidence that is discarded.
Modification
Precompute font scales, upright bounds and reference-marker features within each matching pass. Compute strong script roles only when consumed. Prefilter same-baseline pairs by necessary classification conditions and delay table-obstacle checks until geometry matches, preserving pair order and merge decisions.
This is stage 2/6 of the Flash PDF equivalence refactor, based on
codex/flash-pdf-01-baseline. Review and integrate stages in order.Validation
31 documents / 298 pages retain identical complete model-list and Middle JSON output. 65 focused tests pass, including cache lifetime and linear font-statistic work. Four representative five-run medians improve by 11.8%–34.4%; peak RSS remains within 0.4% of baseline.
The original
test_demo_sparse_table_confidence_manifestbbox expectation failure is documented separately and its expected data is not modified.Compatibility
The existing
PdfModel.predict(), PDFDocument methods, ModelJson/MiddleJson output and renderer contracts remain unchanged. Recognition thresholds, candidate priority and fallback behavior are preserved.Checklist
git diff --checkpass.