fix: make syslog optional to prevent crash in Docker - #4
Merged
Conversation
syslog.New() fails in containers without a syslog daemon, causing os.Exit(1). Make syslog optional — fall back to stdout-only logging when unavailable.
Fall back to /var/log/taskmaster.log when syslog is unavailable, rather than silently dropping syslog messages.
mylastresort
force-pushed
the
fix/syslog-crash-in-docker
branch
from
July 23, 2026 11:00
fcb0fcd to
8b3a392
Compare
mylastresort
marked this pull request as ready for review
July 23, 2026 21:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The server crashes immediately on startup inside a Docker container:
calls which requires a running syslog daemon. Docker containers don't have one by default, so the connection fails and is called.
Fix