Skip to content

NAT probe fixes #3747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Snawoot merged 1 commit into from
Aug 9, 2021
Merged

NAT probe fixes #3747

Snawoot merged 1 commit into from
Aug 9, 2021

Conversation

@Snawoot
Copy link
Contributor

@Snawoot Snawoot commented Aug 6, 2021 •
edited
Loading

Fixes:

  • There was a slight possibility of goroutine leak under rare race condition when probe was cancelled but listening goroutine is still trying to deliver message into channel.
  • Fix handling of garbage packets:
    • Incorrect packets silently ignored, it is still possible we'll receive answer from STUN-server.
    • Oversized packets silently ignored, they may be garbage too.

@Snawoot Snawoot marked this pull request as ready for review August 6, 2021 12:10
@Snawoot Snawoot merged commit 03263e4 into master Aug 9, 2021
@Snawoot Snawoot deleted the natprobe_fixes branch August 9, 2021 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soffokl soffokl soffokl approved these changes

@mdomasevicius mdomasevicius mdomasevicius approved these changes

@tadaskay tadaskay Awaiting requested review from tadaskay

@tomasmik tomasmik Awaiting requested review from tomasmik

@vkuznecovas vkuznecovas Awaiting requested review from vkuznecovas

@Waldz Waldz Awaiting requested review from Waldz Waldz is a code owner

@zolia zolia Awaiting requested review from zolia

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Snawoot @soffokl @mdomasevicius