Port check routine #3753
Merged
Port check routine #3753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snawoot
requested review from
Waldz,
mdomasevicius,
soffokl,
tadaskay,
tomasmik,
vkuznecovas and
zolia
as code owners
vkuznecovas
approved these changes
Aug 10, 2021
core/port/reachability.go
Outdated
|
|
||
| for _, address := range echoServerAddresses { | ||
| go func(echoServerAddress string) { | ||
| err := func() error { |
Contributor
There was a problem hiding this comment.
seems like a perfect candidate to extract to a separate function
core/port/reachability.go
Outdated
| responseChan := make(chan struct{}) | ||
|
|
||
| // Background context-aware receiver | ||
| go func() { |
Contributor
There was a problem hiding this comment.
Id also extract this as a separate func, can assign a comprehendable name to it then.
Codecov Report
@@ Coverage Diff @@
## master #3753 +/- ##
==========================================
- Coverage 43.99% 43.86% -0.14%
==========================================
Files 323 324 +1
Lines 16525 16588 +63
==========================================
+ Hits 7270 7276 +6
- Misses 8503 8559 +56
- Partials 752 753 +1
Continue to review full report at Codecov.
|
Co-authored-by: Viktoras <vkuznecovas@users.noreply.github.com>
tomasmik
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements external UDP port check routine.
Not integrating routine into node in this PR for two reasons: