Skip to content

Check we have goimports #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Waldz merged 4 commits into from
Oct 18, 2018
+3 −1
Merged

Check we have goimports #453

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a43d97
Add newline to end of shell script
tcharding Oct 18, 2018
b4787cc
Add missing 'set -e' to shell script
tcharding Oct 18, 2018
269657e
Merge branch 'master' into functions
Waldz Oct 18, 2018
13a1d16
Merge branch 'master' into functions
Waldz Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bin/check_goimports
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
#> bin/check_goimports ./communication
#> bin/check_goimports ./communication/...

set -e

source bin/helpers/output.sh

ARGUMENTS=$@
Expand All @@ -28,4 +30,4 @@ if [ ! -z "$unformatted" ]; then
fi

print_success "All files are compliant to goimports."
exit 0
exit 0
Copy link
Copy Markdown
Contributor Author

@tcharding tcharding Oct 17, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't seem to get an editor to edit this file without adding these 'exit 0' lines to the diff. I tried emacs and vim?

Copy link
Copy Markdown
Member

@soffokl soffokl Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok, it's even better to have a new line at the end of the file.

Copy link
Copy Markdown
Contributor Author

@tcharding tcharding Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 that is my opinion also. I'll add the newline in a separate patch and force push.

Copy link
Copy Markdown
Contributor Author

@tcharding tcharding Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added newline.