Conversation
| service_noop "github.com/mysteriumnetwork/node/services/noop" | ||
| service_openvpn "github.com/mysteriumnetwork/node/services/openvpn" | ||
| openvpn_service "github.com/mysteriumnetwork/node/services/openvpn/service" | ||
| service_wireguard "github.com/mysteriumnetwork/node/services/wireguard" |
There was a problem hiding this comment.
There is clearly something wrong with package structure inside openvpn :( service_openvpn and openvpn_service? I know it's out of this PR scope, but please don't do it with wireguard too :)
tadovas
left a comment
tadovas
left a comment
There was a problem hiding this comment.
Approving this as skeleton. But so much work to be done for now. Maybe wireguard should not be started by default at the moment
| // } | ||
|
|
||
| // TODO wireguard device configuration like private key, listen port, peer list should survive through restarts. | ||
| // TODO we need to have some persistent storage for it. |
There was a problem hiding this comment.
We can create separate ticket for that. Its not high priority IMHO.
| // }) | ||
|
|
||
| // TODO if the wireguard interface already configured we can get required parameters from it. | ||
| // device, err := client.Device("wg0") |
There was a problem hiding this comment.
WG device name should be selected only after listing all active devices. Then choosing free number. We should know which device constitutes which session.
zolia
left a comment
zolia
left a comment
There was a problem hiding this comment.
Its good to have a frame. Let merge this.
|
After sync with master :) |
4 participants
Closes #502