fixed parsing of utf strings with boms for windows#819
Merged
vkuznecovas merged 1 commit intomasterfrom Mar 26, 2019
Merged
Conversation
zolia
previously approved these changes
Mar 25, 2019
vkuznecovas
force-pushed
the
bug/bom-utf8
branch
from
18bf34a to
d9a3483
Compare
zolia
approved these changes
Mar 25, 2019
soffokl
approved these changes
Mar 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, we've got an issue where ICS commands will fail on some win7 machines due to BOM being present in the output of a powershell command. This fixes it by removing the bom from the results.