Conversation
vkuznecovas
left a comment
There was a problem hiding this comment.
I'm not sure. I think the implementation should account for the fact that most of the service providers will be running 24/7 for months at a time with no service restarts. Therefore I think we should periodically update the list of allowed ID's and:
a) don't let anyone who's not whitelisted access our service
b) remove active sessions from ID's that are not whitelisted(since the list might change)
| registered, err := di.IdentityRegistry.IsRegistered(peerID) | ||
| if err != nil { | ||
| return err | ||
| } else if !registered { |
There was a problem hiding this comment.
It's not.
It's else if just for a smaller number of lines instead of two if. :)
You're totally right - this is what we discussed in grooming meeting before starting implementing, and we agreed (together with business at TL) that we need to do this, but it's not a priority. For starters, it's enough to use the rules which are fetched once. Added a task in https://github.com/mysteriumnetwork/mysterium-vpn/issues/456 not to forget about this thing :) |
Closes #878