Conversation
tadaskay
previously approved these changes
Apr 23, 2019
soffokl
reviewed
Apr 24, 2019
donce
force-pushed
the
bugfix/nat-events
branch
from
aa1ee7c to
b51be98
Compare
vkuznecovas
approved these changes
Apr 24, 2019
soffokl
approved these changes
Apr 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have to admit, I haven't actually tested that proper events are sent in #900. And they aren't - no new fields were sent, because they all were private :D
This fixed events sending and improves internal NAT events structure to be similar to ELK events structure - it simplifies stuff.
#890