Fixed bug where Tr first row check was invalid #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UseFirstRowAsHeaderRow check didn't check if first row of parent table, it checked if same as first existing tr in document.
Owner
|
@zelloxy acknowledge seeing this PR, I am traveling, will check this PR by Wed once I am available. |
Owner
|
Available in v3.11.0 published few mins ago |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UseFirstRowAsHeaderRow check didn't check if first row of parent table, it checked if same as first existing tr in document. The bug occurs when there are more than one table in Html.