test: add integration tests and fix denyAccessPretty branch testability

[Copilot]

Unit tests ran only against hand-written stubs with MW_VERSION pinned to 1.45.0, making the backwards-compat branches in ResponseFactory::denyAccessPretty() and the class_alias() blocks in Hooks.php permanently unreachable. No integration coverage existed to verify service-container wiring, hook registration, or real OutputPage state.

ResponseFactory::denyAccessPretty() — remove MW_VERSION dependency

Replace version_compare( MW_VERSION, '1.41', '<' ) with method_exists():

// Before – old branch unreachable in tests (MW_VERSION stubbed to 1.45.0)
if ( version_compare( MW_VERSION, '1.41', '<' ) ) {
    $output->setPageTitle( $msg );
} else {
    $output->setPageTitleMsg( $msg );
}

// After – both branches reachable via any object with/without setPageTitleMsg()
if ( method_exists( $output, 'setPageTitleMsg' ) ) {
    $output->setPageTitleMsg( $msg );
} else {
    $output->setPageTitle( $msg );
}

The CI matrix (REL1_39 + REL1_43) now naturally exercises both paths in integration.

Unit tests — cover both method_exists() branches

• testDenyAccessPrettyCallsSetPageTitleMsgOnModernOutputPage: mock has setPageTitleMsg → asserts it's called, setPageTitle never called.
• testDenyAccessPrettyFallsBackToSetPageTitleOnLegacyOutputPage: anonymous stub deliberately omits setPageTitleMsg → asserts setPageTitle called exactly once.

Integration tests — tests/phpunit/integration/CrawlerProtectionIntegrationTest.php

New MediaWikiIntegrationTestCase suite covering what stubs can never verify:

• Service wiring: both CrawlerProtection.CrawlerProtectionService and CrawlerProtection.ResponseFactory resolve from the real container.
• Hook registration: MediaWikiPerformAction and SpecialPageBeforeExecute are registered with HookContainer.
• Real OutputPage state: denyAccessPretty() sets HTTP 403 on a genuine OutputPage instance.
• End-to-end behaviour: anonymous users are blocked (return false, status 403) on protected actions and special pages; registered users pass through unblocked.

composer.json — scope standalone run to unit tests only

composer phpunit now points to tests/phpunit/unit/ (was tests/phpunit/) so integration tests aren't run without a MediaWiki install. Integration namespace added to autoload-dev.

CI — enable coverage on one job

phpunit matrix converted to explicit include entries with a coverage key. REL1_43/PHP 8.2 runs with coverage: pcov and passes --coverage-text to phpunit; all other jobs remain coverage: none.

• Fixes Tests are unit-only against hand-written stubs; back-compat branches and real wiring are untested (non-functional: testability) #50

[jeffw16]

@copilot Pull the latest changes from the main branch and only then fix all failing pipelines.

[Copilot]

@copilot Pull the latest changes from the main branch and only then fix all failing pipelines.

Merged origin/main into this branch (commit e3d55a5). Resolved conflicts in ci.yml and composer.json, and fixed all integration-test failures found in the previous CI run:

• cliMode bug — behavioral tests (testAnonymous*IsBlocked, testRegisteredUser*IsNotBlocked) now use a makeWebModeService() helper that constructs CrawlerProtectionService with cliMode=false, bypassing the CLI-detection logic in ServiceWiring.php.
• getStatusCode() missing on MW < 1.45 — all assertions on that getter are now guarded by method_exists(), so they run only on REL1_45 and are gracefully skipped on REL1_39/1_43/1_44.
• @covers missing on hook-registration tests — both testMediaWikiPerformActionHookIsRegistered and testSpecialPageBeforeExecuteHookIsRegistered now carry @covers \MediaWiki\Extension\CrawlerProtection\Hooks::__construct.
• PHPCS warnings — trailing comment on same line as code moved to its own line; blank line added after the anonymous-stub setPageTitle() method.

[jeffw16]

@copilot Investigate and fix all failing unit tests

[Copilot]

Pull request overview

This PR improves CrawlerProtection’s testability and confidence across supported MediaWiki versions by making ResponseFactory::denyAccessPretty() feature-detect OutputPage capabilities (instead of branching on MW_VERSION), and by adding MediaWiki integration tests that validate real service wiring, hook registration, and denial behavior.

Changes:

• Update ResponseFactory::denyAccessPretty() to use method_exists() for setPageTitleMsg() vs legacy setPageTitle().
• Add new PHPUnit integration coverage (MediaWikiIntegrationTestCase) for container wiring, hook registration, and end-to-end blocking behavior.
• Expand CI to run against additional MediaWiki branches and add coverage output for one job; add repo automation/supporting workflows/docs.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
includes/ResponseFactory.php	Switch title-setting back-compat logic to feature detection for testability across MW versions.
tests/phpunit/unit/ResponseFactoryTest.php	Add unit tests to cover both method_exists() branches of the title-setting logic.
tests/phpunit/integration/CrawlerProtectionIntegrationTest.php	Add integration tests for service wiring, hook registration, and real OutputPage 403 behavior.
.github/workflows/ci.yml	Extend MW matrix and add a coverage-enabled PHPUnit variant.
composer.json	Add/adjust dev tooling (e.g., minus-x) and autoload-dev for integration tests.
.github/workflows/copilot-setup-steps.yml	Add a workflow to provision dependencies for Copilot cloud agent tasks.
TESTING.md	Update guidance for updating the build submodule.
Makefile	Stop using --remote when initializing the build submodule.
.github/instructions/mediawiki-extensions.instructions.md	Adjust applyTo glob.
.github/instructions/mediawiki-extensions-clean-code.instructions.md	Adjust applyTo glob.
.github/instructions/crawlerprotection-testing.instructions.md	Add repository-specific testing guidance for Copilot.
.github/instructions/crawlerprotection-release-i18n.instructions.md	Add repository-specific release/i18n/JSON guidance for Copilot.
.github/instructions/crawlerprotection-architecture.instructions.md	Add repository-specific architecture/security guidance for Copilot.
.github/copilot-instructions.md	Add repo “source of truth” Copilot instructions.
.github/dependabot.yml	Add Dependabot configuration for composer/actions/submodules.

[Copilot]

@copilot Investigate and fix all failing unit tests

Fixed in 65eea6f. The failures were all cross-version class-resolution problems in the integration test:

• REL1_39 — createMock( \MediaWiki\User\User::class ) failed ("Cannot stub or mock class ... which does not exist"); User was not namespaced until later releases. Anonymous users are now built with UserFactory::newAnonymous(), which returns a real User on every supported version.
• REL1_44 / REL1_45 — \Title and \FauxRequest no longer exist as global aliases. Title is now created via TitleFactory::makeTitle(), and FauxRequest is resolved at run time (MediaWiki\Request\FauxRequest when present, global FauxRequest otherwise — 1.39 only ships the latter, 1.45 only the former).

REL1_43 was passing before and is unaffected. PHPCS is clean.