Skip to content

Conversation

@elsirion
Copy link

@elsirion elsirion commented May 16, 2025

Description

This PR adds a nix flake with packages for the iroh-dns-server and iroh-relay binaries as well as a rust dev shell for development. To make the packaging work better (less redundant versions in nix flake) I also made the crate versions a workspace property that is inherited.

Breaking Changes

None to my knowledge.

Notes & open questions

  • Should the .envrc file be part of this PR? It automatically activates the dev shell via direnv if set up and allowed.
  • Should the cargo changes be split into a separate commit?
  • Does the nix dev shell need docs? I'd just assume fellow nixers will recognize it being there and be happyy while others will keep doing whatever they were doing before.
  • Longer term, out of scope here imo: should more things like dependencies be moved to the workspace (can recommend, we did that with Fedimint
    and it made changes much more manageable)

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant. See question above
  • Tests if relevant. Don't think it's relevant.

This commit adds packages for the iroh-dns-server and iroh-relay
binaries as well as a rust dev shell for development. To make the
packaging work better (less redundant versions in ni flake) I also
made the crate versions a workspace property that is inherited.
@n0bot n0bot bot added this to iroh May 16, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh May 16, 2025
@flub
Copy link
Contributor

flub commented Jun 2, 2025

Hi, for folks who don't use nix at all could you add some context? Does having this make a big difference to nix users? Is is impossible to do this out-of-project? Once concern I have for example is that this looks like it needs to be kept up-to-date, which is not great if the maintainers don't use it.

@elsirion
Copy link
Author

elsirion commented Jun 4, 2025

The benefit for nix users over an out-of-repo version would be that they will see that a packaged version is available and can get started deploying/developing without much friction. Tbf that's a rather minimal improvement since packaging turned out to be quite simple, for more complicated to build projects it can save a lot of headaches.

@elsirion elsirion closed this Jun 10, 2025
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants