Skip to content

chore: unify nat traversal naming#445

Merged
matheus23 merged 3 commits into
mainfrom
unify-nat-traversal-naming
Feb 23, 2026
Merged

chore: unify nat traversal naming#445
matheus23 merged 3 commits into
mainfrom
unify-nat-traversal-naming

Conversation

@divagant-martian

Copy link
Copy Markdown
Collaborator

Description

Closes #370

Uses n0 instead of iroh, nat traversal instead of hole punching

Breaking Changes

pub mod has been renamed from iroh_hp to n0_nat_traversal

Notes & open questions

n/a

@divagant-martian divagant-martian added this to the quinn: iroh 0.97 milestone Feb 21, 2026
@divagant-martian divagant-martian added holepunching refactor QNT QUIC NAT Traversal extension and all holepunching issues labels Feb 21, 2026
@divagant-martian divagant-martian self-assigned this Feb 21, 2026
@divagant-martian
divagant-martian requested a review from a team February 21, 2026 00:27
@github-actions

github-actions Bot commented Feb 21, 2026

Copy link
Copy Markdown

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/quinn/pr/445/docs/iroh_quinn/

Last updated: 2026-02-21T12:56:17Z

@codecov-commenter

codecov-commenter commented Feb 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 21.42857% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.24%. Comparing base (c69a939) to head (01bbfa8).

Files with missing lines Patch % Lines
quinn-proto/src/connection/mod.rs 29.72% 26 Missing ⚠️
quinn/src/connection.rs 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   77.16%   77.24%   +0.07%     
==========================================
  Files          81       81              
  Lines       23377    23397      +20     
==========================================
+ Hits        18039    18072      +33     
+ Misses       5338     5325      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Feb 21, 2026

Copy link
Copy Markdown

Performance Comparison Report

f099689480a01a153621d91039e61f5de894de68 - artifacts

Raw Benchmarks (localhost)

Scenario iroh-quinn upstream Delta CPU (avg/max)
large-single 5760.0 Mbps 7978.6 Mbps -27.8% 97.0% / 98.4%
medium-concurrent 5402.3 Mbps 7720.6 Mbps -30.0% 95.3% / 97.2%
medium-single 4484.6 Mbps 4673.9 Mbps -4.0% 95.3% / 97.9%
small-concurrent 3593.2 Mbps 5353.8 Mbps -32.9% 96.1% / 98.2%
small-single 3581.6 Mbps 4774.7 Mbps -25.0% 96.9% / 98.8%

Netsim Benchmarks (network simulation)

Condition iroh-quinn upstream Delta
ideal 2874.4 Mbps 3939.1 Mbps -27.0%
lan 782.5 Mbps 810.4 Mbps -3.4%
lossy 69.8 Mbps 55.9 Mbps +25.0%
wan 83.8 Mbps 83.8 Mbps ~0%

Summary

iroh-quinn is 24.7% slower on average

---
01bbfa8a69bd474bd451408de5a25c9675cf2fe9 - artifacts

Raw Benchmarks (localhost)

Scenario iroh-quinn upstream Delta CPU (avg/max)
large-single 5348.2 Mbps 7995.8 Mbps -33.1% 92.9% / 97.4%
medium-concurrent 5323.1 Mbps 7621.1 Mbps -30.2% 94.7% / 132.0%
medium-single 3929.9 Mbps 4749.5 Mbps -17.3% 92.4% / 106.0%
small-concurrent 3594.9 Mbps 5305.7 Mbps -32.2% 99.2% / 136.0%
small-single 3385.4 Mbps 4727.4 Mbps -28.4% 87.1% / 96.3%

Netsim Benchmarks (network simulation)

Condition iroh-quinn upstream Delta
ideal 2947.1 Mbps N/A N/A
lan 782.4 Mbps N/A N/A
lossy 69.8 Mbps N/A N/A
wan 83.8 Mbps N/A N/A

Summary

iroh-quinn is 29.0% slower on average

@n0bot n0bot Bot added this to iroh Feb 21, 2026
@github-project-automation github-project-automation Bot moved this to 🚑 Needs Triage in iroh Feb 21, 2026
@matheus23
matheus23 added this pull request to the merge queue Feb 23, 2026
Merged via the queue into main with commit 565ebec Feb 23, 2026
36 checks passed
@matheus23
matheus23 deleted the unify-nat-traversal-naming branch February 23, 2026 09:12
@github-project-automation github-project-automation Bot moved this from 🚑 Needs Triage to ✅ Done in iroh Feb 23, 2026
@flub flub removed the holepunching label Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QNT QUIC NAT Traversal extension and all holepunching issues refactor

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

unify hp/nat traversal naming

5 participants