chore: unify nat traversal naming#445
Merged
Merged
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/quinn/pr/445/docs/iroh_quinn/ Last updated: 2026-02-21T12:56:17Z |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #445 +/- ##
==========================================
+ Coverage 77.16% 77.24% +0.07%
==========================================
Files 81 81
Lines 23377 23397 +20
==========================================
+ Hits 18039 18072 +33
+ Misses 5338 5325 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Performance Comparison Report
|
| Scenario | iroh-quinn | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5760.0 Mbps | 7978.6 Mbps | -27.8% | 97.0% / 98.4% |
| medium-concurrent | 5402.3 Mbps | 7720.6 Mbps | -30.0% | 95.3% / 97.2% |
| medium-single | 4484.6 Mbps | 4673.9 Mbps | -4.0% | 95.3% / 97.9% |
| small-concurrent | 3593.2 Mbps | 5353.8 Mbps | -32.9% | 96.1% / 98.2% |
| small-single | 3581.6 Mbps | 4774.7 Mbps | -25.0% | 96.9% / 98.8% |
Netsim Benchmarks (network simulation)
| Condition | iroh-quinn | upstream | Delta |
|---|---|---|---|
| ideal | 2874.4 Mbps | 3939.1 Mbps | -27.0% |
| lan | 782.5 Mbps | 810.4 Mbps | -3.4% |
| lossy | 69.8 Mbps | 55.9 Mbps | +25.0% |
| wan | 83.8 Mbps | 83.8 Mbps | ~0% |
Summary
iroh-quinn is 24.7% slower on average
01bbfa8a69bd474bd451408de5a25c9675cf2fe9 - artifacts
Raw Benchmarks (localhost)
| Scenario | iroh-quinn | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5348.2 Mbps | 7995.8 Mbps | -33.1% | 92.9% / 97.4% |
| medium-concurrent | 5323.1 Mbps | 7621.1 Mbps | -30.2% | 94.7% / 132.0% |
| medium-single | 3929.9 Mbps | 4749.5 Mbps | -17.3% | 92.4% / 106.0% |
| small-concurrent | 3594.9 Mbps | 5305.7 Mbps | -32.2% | 99.2% / 136.0% |
| small-single | 3385.4 Mbps | 4727.4 Mbps | -28.4% | 87.1% / 96.3% |
Netsim Benchmarks (network simulation)
| Condition | iroh-quinn | upstream | Delta |
|---|---|---|---|
| ideal | 2947.1 Mbps | N/A | N/A |
| lan | 782.4 Mbps | N/A | N/A |
| lossy | 69.8 Mbps | N/A | N/A |
| wan | 83.8 Mbps | N/A | N/A |
Summary
iroh-quinn is 29.0% slower on average
dignifiedquire
approved these changes
Feb 21, 2026
matheus23
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #370
Uses n0 instead of iroh, nat traversal instead of hole punching
Breaking Changes
pub mod has been renamed from
iroh_hpton0_nat_traversalNotes & open questions
n/a