feat(proto): Mark PathEvent as #[non_exhaustive]#648
Merged
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/noq/pr/648/docs/noq/ Last updated: 2026-05-21T14:30:48Z |
Performance Comparison Report
|
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5659.8 Mbps | 7948.1 Mbps | -28.8% | 97.5% / 148.0% |
| medium-concurrent | 5395.0 Mbps | 8028.9 Mbps | -32.8% | 95.9% / 147.0% |
| medium-single | 4384.6 Mbps | 4580.7 Mbps | -4.3% | 92.0% / 101.0% |
| small-concurrent | 3809.5 Mbps | 5261.4 Mbps | -27.6% | 94.3% / 101.0% |
| small-single | 3588.7 Mbps | 4801.6 Mbps | -25.3% | 98.0% / 151.0% |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | 3063.9 Mbps | N/A | N/A |
| lan | 782.4 Mbps | N/A | N/A |
| lossy | 69.8 Mbps | N/A | N/A |
| wan | 83.8 Mbps | N/A | N/A |
Summary
noq is 25.4% slower on average
fc551f37b2748b5fc85dcb1edc82e6f6cd797789 - artifacts
Raw Benchmarks (localhost)
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5441.1 Mbps | 7897.7 Mbps | -31.1% | 94.3% / 100.0% |
| medium-concurrent | 5413.6 Mbps | 7518.9 Mbps | -28.0% | 93.5% / 100.0% |
| medium-single | 3816.1 Mbps | 4700.2 Mbps | -18.8% | 94.5% / 102.0% |
| small-concurrent | 3830.6 Mbps | 5231.1 Mbps | -26.8% | 98.7% / 154.0% |
| small-single | 3428.8 Mbps | 4738.5 Mbps | -27.6% | 90.4% / 98.4% |
Summary
noq is 27.1% slower on average
8d720019675f1cfff950e2f28ed02d60b806efcc - artifacts
Raw Benchmarks (localhost)
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5762.1 Mbps | 7953.0 Mbps | -27.5% | 94.5% / 101.0% |
| medium-concurrent | 5600.4 Mbps | 7676.2 Mbps | -27.0% | 93.3% / 99.0% |
| medium-single | 4032.3 Mbps | 4589.5 Mbps | -12.1% | 94.7% / 101.0% |
| small-concurrent | 3925.7 Mbps | 5193.5 Mbps | -24.4% | 99.3% / 153.0% |
| small-single | 3553.4 Mbps | 4745.7 Mbps | -25.1% | 89.6% / 97.4% |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | 3072.4 Mbps | 3980.5 Mbps | -22.8% |
| lan | 782.4 Mbps | 796.4 Mbps | -1.8% |
| lossy | 69.8 Mbps | 55.9 Mbps | +25.0% |
| wan | 83.8 Mbps | 83.8 Mbps | ~0% |
Summary
noq is 23.4% slower on average
794f0f33663a5e56d51c12e2dd988eb0d10e6e5b - artifacts
No results available
09b22ded8600edcf7aab5bef7b23ab60c5f3bb78 - artifacts
Raw Benchmarks (localhost)
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5387.0 Mbps | 7863.7 Mbps | -31.5% | 92.9% / 99.0% |
| medium-concurrent | 5417.3 Mbps | 7613.9 Mbps | -28.8% | 93.8% / 99.0% |
| medium-single | 4153.1 Mbps | 4749.5 Mbps | -12.6% | 94.6% / 101.0% |
| small-concurrent | 3713.5 Mbps | 5370.3 Mbps | -30.8% | 98.1% / 152.0% |
| small-single | 3502.0 Mbps | 4717.8 Mbps | -25.8% | 89.5% / 97.5% |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | 3092.0 Mbps | 4093.0 Mbps | -24.5% |
| lan | 782.4 Mbps | 810.3 Mbps | -3.4% |
| lossy | 69.8 Mbps | 55.9 Mbps | +25.0% |
| wan | 83.8 Mbps | 83.8 Mbps | ~0% |
Summary
noq is 25.9% slower on average
flub
reviewed
May 13, 2026
flub
approved these changes
May 20, 2026
matheus23
force-pushed
the
matheus23/path-event-non-exhaustive
branch
from
May 21, 2026 14:25
8d72001 to
794f0f3
Compare
matheus23
force-pushed
the
matheus23/path-event-non-exhaustive
branch
from
May 21, 2026 14:27
794f0f3 to
09b22de
Compare
matheus23
enabled auto-merge
May 21, 2026 14:27
1 task
dignifiedquire
pushed a commit
to n0-computer/iroh
that referenced
this pull request
May 22, 2026
## Description Updates to the latest main, including `#[non_exhaustive]` changes to `PathEvent`: n0-computer/noq#648 ## Notes & open questions Adding a `#[cfg(test)] panic!()` to ensure we keep the versions in noq and iroh in sync and see iroh tests failing when we add more path events. ## Change checklist <!-- Remove any that are not relevant. --> - [x] Self-review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is for future-proofing the API.
Closes #642
Breaking Changes
enum PathEventand all of its cases are now marked as#[non_exhaustive]Notes & open questions
I'm ignoring the
_ =>case, as anything else would mean we would "do something" in case e.g. noq is bound against a newer noq-proto.In
#[cfg(test)]however, I panic, as in that case the version we depend on must be up to date.Change checklist