ci(secruity): hardening + lock files + dependabot cooldown - #48
Merged
Conversation
The repo had none, so nothing was ever proposed for update. Actions need this in place before pinning, or the pins freeze permanently. Cooldown lets a compromised publish be noticed before we take it.
Turns a warning to spot in the log into a hard failure in the deny job. chacha20 0.10.1 was yanked; h2 0.4.15 carries RUSTSEC-2026-0258 (unbounded empty DATA frames), which the deny job was already failing on. Both bumped.
ci.yml had no permissions block at all. release-rolling.yml granted contents: write to the whole workflow, including the two build jobs; only publish-rolling needs it.
actions/checkout leaves the job token in .git/config by default, where any build script can read it. Only publish-rolling needs it: it moves the rolling tag with a bare git push.
…action publish-rolling is the only job holding contents: write. gh ships on the runner, so the release can be cut without trusting an extra action in that job. Behaviour is unchanged: same tag, title, prerelease flag, non-latest, notes and asset set.
--locked everywhere so a job can never silently resolve a dependency the lockfile does not name. cargo make rejects the flag, so that step asserts the lockfile did not move instead. The UI side was already on npm ci against a committed package-lock.json.
Expressions interpolated straight into a run block are substituted before the shell sees them, so anything attacker-influenced becomes code. Bind them to env and quote the reads instead.
zizmor audits the workflows themselves; pinact fails if a pinned SHA drifts from its version comment or is younger than the cooldown. No zizmor config: the tree is clean with no accepted exceptions.
Frando
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same pricinple as n0-computer/noq#788
Uses --locked to ensure we only use deps from the lock file
Adds cooldown period to dependabot
pins actions versions
introduces zizimor and pinact