Skip to content

Conversation

@netroy
Copy link
Contributor

@netroy netroy commented Jun 4, 2025

Summary

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jun 4, 2025
@netroy netroy force-pushed the community-packages-as-module branch from 147dbf1 to 832f9d8 Compare June 4, 2025 18:02
@codecov
Copy link

codecov bot commented Jun 4, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
5613 2 5611 0
View the top 2 failed test(s) by shortest run time
 should report community nodes
Stack Traces | 0.002s run time
Error: Expected test audit not to be an array
    at getRiskSection (.../integration/security-audit/utils.ts:23:9)
    at Object.<anonymous> (.../integration/security-audit/nodes-risk-reporter.test.ts:106:32)
 should report security settings
Stack Traces | 0.011s run time
Error: expect(received).toMatchObject(expected)

- Expected  - 1
+ Received  + 1

@@ -1,8 +1,8 @@
  Object {
    "features": Object {
-     "communityPackagesEnabled": true,
+     "communityPackagesEnabled": false,
      "publicApiEnabled": false,
      "templatesEnabled": true,
      "versionNotificationsEnabled": true,
    },
    "nodes": Object {
    at Object.<anonymous> (.../integration/security-audit/instance-risk-reporter.test.ts:252:27)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@ivov
Copy link
Member

ivov commented Aug 6, 2025

@netroy Thanks for working on this! I'm slowly modularizing community packages as I find the time using your work as reference, so this was definitely useful 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants