Consistent migration lifecycle to ensure beforeMigration and afterMigration are always called

[netroy]

typeorm#7922 added the code to disable/enable foreign key checks for sqlite when running migrations individually, but is missing the code do so when the migrations are run via connection.runMigrations().
This change ensures a consistent behavior between all the code paths.

[despairblue]

Looks ok, but I'm wondering about one thing.

If this.transaction is all wouldn't we commit outside of a transaction?

First this runs:

typeorm/src/migration/MigrationExecutor.ts

Lines 304 to 308 in 9e457d6

	if (this.transaction === "all" && !queryRunner.isTransactionActive) {
	await queryRunner.beforeMigration()
	await queryRunner.startTransaction()
	transactionStartedByUs = true
	}

Then let's assume there is only one migration.
This is skipped, because queryRunner.isTransactionActive is true:

typeorm/src/migration/MigrationExecutor.ts

Lines 321 to 325 in 9e457d6

	if (migration.transaction && !queryRunner.isTransactionActive) {
	await queryRunner.beforeMigration()
	await queryRunner.startTransaction()
	transactionStartedByUs = true
	}

Then we commit, since transactionStartedByUs is true:

typeorm/src/migration/MigrationExecutor.ts

Lines 334 to 336 in 9e457d6

	if (migration.transaction && transactionStartedByUs) {
	await queryRunner.commitTransaction()
	}

Then this runs, because transactionStartedByUs is still true:

typeorm/src/migration/MigrationExecutor.ts

Lines 359 to 361 in 9e457d6

	if (this.transaction === "all" && transactionStartedByUs) {
	await queryRunner.commitTransaction()
	}

So we're

1. starting transaction
2. don't start another one
3. commit the transaction
4. try to commit again

Or am I missing something?