Use native operations for more schema related operations in the sqlite driver #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivov
approved these changes
Apr 30, 2025
Member
ivov
left a comment
ivov
left a comment
There was a problem hiding this comment.
Looks good on the face of it, but I'm not deeply familiar with this lib!
Is there a chance they would upstream this?
Comment on lines
+497
to
+502
| if (shouldRecreateTable) { | ||
| const changedTable = table.clone() | ||
| columns.forEach((column) => changedTable.addColumn(column)) | ||
| await this.recreateTable(changedTable, table) | ||
| return | ||
| } |
Member
There was a problem hiding this comment.
Should we log a warning here? Same for other cases that require recreating.
| const tableColumn = table.columns.find( | ||
| (column) => column.name === oldColumn.name, | ||
| ) | ||
| if (tableColumn) { |
Member
There was a problem hiding this comment.
Should we throw if not found instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many schema operations that sqlite has supported natively for years, but the sqlite driver hasn't implemented, and instead we end up re-creating entire tables for these operations, which when foreign-key constraints are enabled, leads to data-loss.
This PR re-implements some of these operations using native queries, whenever possible.