マイグレーション検証で補足が必要に思えた点について追記 - #691
Merged
Merged
Conversation
kankichi00
reviewed
Mar 26, 2025
| <configuration> | ||
| ... | ||
|
|
||
| また、 変更前バージョンではJava 17で使用するために `Java 17での設定ガイド (外部サイト) <https://github.com/coastland/gsp-dba-maven-plugin/tree/4.x.x-main?tab=readme-ov-file#java17%E3%81%A7%E3%81%AE%E8%A8%AD%E5%AE%9A>`_ に沿って依存関係を追加しているが、バージョンアップ後にはこの設定が不要となるため、追加した依存関係を削除する。 |
Contributor
There was a problem hiding this comment.
丁寧すぎるかもしれませんが、バージョンアップ後は設定が組み込まれたので不要となったと記載した方が分かりやすいかと思いました。
、バージョンアップ後にはこの設定は組み込まれており不要となるため、追加した依存関係を削除する。
kankichi00
pushed a commit
that referenced
this pull request
Mar 28, 2025
* マイグレーション検証で補足が必要に思えた点について追記 * 表現を修正 * マイグレーション検証で補足が必要に思えた点について追記（英語版）
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.