fix: add ClusterName for Kubernetes API calls in secret resolvers #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix incorrectly removed ClusterName() from all operations. However, Kubernetes API calls need cluster names (prod), while watcher cache lookups use environment names (prod-gcp). This adds ClusterName() back for: - All mutations (Create, Add, Update, Remove, Delete) - use SystemAuthenticatedClient - GetSecretValues - uses impersonated Client Watcher lookups (Get, ListForWorkload) correctly use environment names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The previous fix (PR #312) incorrectly removed
ClusterName()from ALL operations. This causedEnvironment "prod-gcp" does not existerrors when trying to read secret values.Root cause
There are two different systems with different naming conventions:
prod-gcp)prod)Fix
Add
ClusterName()back for Kubernetes API calls:SystemAuthenticatedClientGetSecretValues- uses impersonatedClientWatcher lookups (
Get,ListForWorkload) correctly use environment names (from PR #312).