Skip to content

Enhance SBOM handling with new types, resolvers, and tests #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ybelMekk wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Enhance SBOM handling with new types, resolvers, and tests #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
0329b9a
chore: add local replace directive for v13s/pkg/api
ybelMekk May 15, 2026
4a82af2
feat(vulnerability): add SBOMStatus type, ContainerImageSBOM, dataloa…
ybelMekk May 15, 2026
7fde085
feat(graphql): add ContainerImageSBOM type, SBOMStatus enum and depre…
ybelMekk May 15, 2026
343a339
feat(graphql): add resolvers for ContainerImageSBOM status and proces…
ybelMekk May 15, 2026
61e2b60
refactor(issue): migrate SBOM check from HasSbom to SbomStatus
ybelMekk May 15, 2026
ed2c650
test: update fake and integration test for SbomStatus
ybelMekk May 15, 2026
125b55a
refactor(vulnerability): update fake and queries for repeated Workloa…
ybelMekk May 15, 2026
6e867a5
refactor(vulnerability): update to workload_refs=2 and sbom_status=3
ybelMekk May 15, 2026
d0fe5e4
fix: update WorkloadRefs to WorkloadRef after v13s proto rename
ybelMekk May 15, 2026
a2c47d1
chore: use latest v13s main instead of local replace
ybelMekk May 18, 2026
56539ef
fix(vulnerability): always return non-nil ImageVulnerabilitySummary
ybelMekk May 18, 2026
1f793b0
fix(vulnerability): cap batch loader concurrency to 10 goroutines
ybelMekk May 18, 2026
e75d889
fix(vulnerability): derive SbomStatus from summary.HasSbom in fake cl…
ybelMekk May 18, 2026
d76fd6c
fix(vulnerability): fall back to UNSPECIFIED for unknown SBOMStatus v…
ybelMekk May 18, 2026
e7d4391
chore: remove blank line in transform.go (gofumpt)
ybelMekk May 18, 2026
0fa6097
vulnerability: derive HasSbom from SbomStatus, remove dead wg.Wait er…
ybelMekk May 18, 2026
5106c16
vulnerability: assert processingStartedAt in integration test
ybelMekk May 18, 2026
ea4be1d
vulnerability: fall back to PROCESSING for unknown SBOMStatus values
ybelMekk May 18, 2026
42fe1bd
vulnerability: surface stale image tag, handle NotFound as empty resp…
ybelMekk May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ require (
github.com/nais/pgrator/pkg/api v0.0.0-20260219115817-cf954d58c04e
github.com/nais/tester v0.1.1
github.com/nais/unleasherator v0.0.0-20251216221129-efebc54203fe
github.com/nais/v13s/pkg/api v0.0.0-20260513133039-3688f23180a9
github.com/nais/v13s/pkg/api v0.0.0-20260518075555-712972410146
github.com/patrickmn/go-cache v2.1.0+incompatible
github.com/pressly/goose/v3 v3.27.0
github.com/prometheus/client_golang v1.23.2
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,8 +813,8 @@ github.com/nais/tester v0.1.1 h1:tpJ5HKpu3mEIWX/mec0Yj0xLHEpt+MwTAsj282n0Py0=
github.com/nais/tester v0.1.1/go.mod h1:NCQMcgftHz/EXorob1XwDTOqkQmImDqr51YQ2Uea9Pc=
github.com/nais/unleasherator v0.0.0-20251216221129-efebc54203fe h1:CdRVopOihru4tXVwKZjhg6C8SbPLCQYOhJKpjBZYhjg=
github.com/nais/unleasherator v0.0.0-20251216221129-efebc54203fe/go.mod h1:Tiz/1If3WgcfvNhmsO5DiQC+L+1XhBG3KWbIfbjx4EU=
github.com/nais/v13s/pkg/api v0.0.0-20260513133039-3688f23180a9 h1:ZCp9qXbxY37ZZQn0BD/l/OXOKBevDkEZ84hrWITmQiE=
github.com/nais/v13s/pkg/api v0.0.0-20260513133039-3688f23180a9/go.mod h1:Eafi4ZFv3tUGkhRnBtLRUii3S4kzLvdgDbYAvdiyauU=
github.com/nais/v13s/pkg/api v0.0.0-20260518075555-712972410146 h1:chxnrlBrrQ8ag7unA83LaFCxOjYYJou/ptUoyBXngaA=
github.com/nais/v13s/pkg/api v0.0.0-20260518075555-712972410146/go.mod h1:Eafi4ZFv3tUGkhRnBtLRUii3S4kzLvdgDbYAvdiyauU=
github.com/ncruces/go-sqlite3 v0.32.0 h1:hNBUXp88LrfQCsuyXLqWTbTUG35sUuktDsqhhgHvU20=
github.com/ncruces/go-sqlite3 v0.32.0/go.mod h1:MIWTK60ONDl0oVY073zYvJP21C3Dly6P9bxVpgkLwdQ=
github.com/ncruces/go-strftime v1.0.0 h1:HMFp8mLCTPp341M/ZnA4qaf7ZlsbTc+miZjCLOFAw7w=
Expand Down
8 changes: 8 additions & 0 deletions integration_tests/vulnerabilities.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ Test.gql("List vulnerability summaries for team", function(t)
image{
name
hasSBOM
sbom {
status
processingStartedAt
}
vulnerabilitySummary{
Comment thread
ybelMekk marked this conversation as resolved.
total
critical
Expand All @@ -80,6 +84,10 @@ Test.gql("List vulnerability summaries for team", function(t)
image = {
name = "europe-north1-docker.pkg.dev/nais/navikt/app-name",
hasSBOM = true,
sbom = {
status = "READY",
processingStartedAt = Ignore(),
},
vulnerabilitySummary = {
total = NotNull(),
critical = NotNull(),
Expand Down
92 changes: 91 additions & 1 deletion internal/graph/gengql/root_.generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions internal/graph/gengql/schema.generated.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading