Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 9, 2025

Describe your changes

  • Build commitment tree and witness map locally
    • Uses leanbridgetree crate for this purpose
    • If the number of blocks to sync exceeds a certain threshold, we race with the local approach, by fetching the commitment tree, witness map and notes index in the background
      • Whatever finishes first is the data we store in the shielded wallet (which should have been identical, regardless of being built locally or fetched from the MASP indexer)
  • Fix block index not being properly used
    • This is the major source of the speed-up in this PR
  • Optimize the layout of the shielded wallet
    • Removed unnecessary fields
  • Only fetch block index after a threshold of $N$ blocks (where it makes sense latency wise to wait for that network query vs. fetching $N$ potentially empty blocks)

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #4785 done by [Mergify](https://mergify.com).

sug0 added 30 commits October 9, 2025 08:55
(cherry picked from commit adcd35a)
(cherry picked from commit 45a2467)
(cherry picked from commit f7ef28f)
(cherry picked from commit a3f44a9)
(cherry picked from commit 46677f2)
(cherry picked from commit 71aeac4)
(cherry picked from commit e704430)
(cherry picked from commit b69a0ae)
(cherry picked from commit 3d7520f)
(cherry picked from commit b7a060b)
(cherry picked from commit eefd0e5)
(cherry picked from commit 9f1083a)
(cherry picked from commit c7fd441)
(cherry picked from commit 4002a26)
(cherry picked from commit e332afc)
sug0 added 13 commits October 9, 2025 08:55
(cherry picked from commit 05ec0f0)
(cherry picked from commit 0161447)
(cherry picked from commit 1b41430)
(cherry picked from commit 6e334f4)
(cherry picked from commit ecb7d4d)
(cherry picked from commit 43e2640)
(cherry picked from commit f97031a)
@mergify
Copy link
Contributor Author

mergify bot commented Oct 9, 2025

🧪 CI Insights

Here's what we observed from your CI run for cb1003d.

🟢 All jobs passed!

But CI Insights is watching 👀

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Oct 9, 2025
@mergify mergify bot added the queued label Oct 9, 2025
mergify bot added a commit that referenced this pull request Oct 9, 2025
@mergify mergify bot merged commit 0e13543 into maint-libs-0.251 Oct 9, 2025
15 of 16 checks passed
@mergify mergify bot deleted the mergify/bp/maint-libs-0.251/pr-4785 branch October 9, 2025 09:05
@mergify mergify bot removed the queued label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants