fix: use workspace:* versions to enable release#2145
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR updates workspace dependency versions across four package manifests in the monorepo. Dependencies previously pinned to a specific preview release version are now resolved to ChangesWorkspace dependency version updates
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryReverts
Confidence Score: 5/5Safe to merge — changes are limited to dependency specifier style and tsconfig scoping in example projects, with no logic changes. All changes are mechanical: two package.json files swap pinned pre-release version strings for workspace:* references, two example tsconfig files drop a browser lib in favour of Node types, and the lockfile is regenerated consistently. The trade-off (docs GQL examples temporarily targeting local code rather than the v1.13 production API) is explicitly acknowledged by the author and tracked for a follow-up revert. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Release PR / Changesets CI] -->|reads package.json specifiers| B{specifier type?}
B -->|workspace:*| C[Resolved to local workspace package\nRelease can proceed ✅]
B -->|pinned snapshot version| D[Changesets tries to update snapshot\nRelease PR blocked ❌]
subgraph Before PR #2145
D
end
subgraph After PR #2145
C
end
C --> E[apps/ensadmin → workspace packages]
C --> F[docs/ensnode.io → workspace packages]
Reviews (4): Last reviewed commit: "fix: include Node.js types for Node.js e..." | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
This PR updates a handful of app/docs/example workspace package dependencies to use workspace:* instead of a pinned preview snapshot version, so that Changesets’ release PR automation can update versions cleanly without getting blocked by hard-coded snapshot strings.
Changes:
- Replace pinned preview snapshot dependency versions with
workspace:*inensadmin, docs (@docs/ensnode), and two examples. - Update
pnpm-lock.yamlimporter entries accordingly and remove the now-unreferenced preview snapshot package/snapshot records.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Converts affected importers to workspace:* + link: and removes unused preview snapshot entries. |
| examples/enssdk-example/package.json | Switches enssdk dependency to workspace:*. |
| examples/enskit-react-example/package.json | Switches enskit and enssdk dependencies to workspace:*. |
| docs/ensnode.io/package.json | Switches @ensnode/ensnode-sdk and enssdk dependencies to workspace:*. |
| apps/ensadmin/package.json | Switches @ensnode/ensnode-sdk and enssdk dependencies to workspace:*. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Otherwise, changests CI action auto-updates the pinned snapshot version: [example](b64fd63#diff-e84a22504342d0e481a7cf29fef59b1d5393caf086c46980f6d4a92adf5280ea).
94505c4 to
4f53834
Compare
|
@greptile revew |
Lite PR
Tip: Review docs on the ENSNode PR process
Summary
workspace:*version references to enable the Release PR to be merged without issuesWhy
v1.13).Testing
Notes for Reviewer (Optional)
v1.13) in ENSNode Docs, we'll need to revert that PR once the release is live.Pre-Review Checklist (Blocking)