Skip to content

fix: use workspace:* versions to enable release#2145

Merged
tk-o merged 2 commits into
mainfrom
fix/use-workspace-versions-to-enable-release
May 19, 2026
Merged

fix: use workspace:* versions to enable release#2145
tk-o merged 2 commits into
mainfrom
fix/use-workspace-versions-to-enable-release

Conversation

@tk-o
Copy link
Copy Markdown
Member

@tk-o tk-o commented May 19, 2026

Lite PR

Tip: Review docs on the ENSNode PR process

Summary

  • For ENSAdmin, and ENSNode Docs, use workspace:* version references to enable the Release PR to be merged without issues

Why

  • In PR docs: add sandbox and ensv2readiness #2103, we've pinned version for ENSNode SDK, ENS SDK, and ENS Kit, in order to support GQL examples working against ENSNode instances in production (ENSNode v1.13).
  • Changests CI action for the Release PR auto-updates the pinned snapshot version: example.

Testing

  • Will be tested by observing CI outputs for the Release PR

Notes for Reviewer (Optional)

  • To continue supporting the ENSApi production release (v1.13) in ENSNode Docs, we'll need to revert that PR once the release is live.

Pre-Review Checklist (Blocking)

  • This PR does not introduce significant changes and is low-risk to review quickly.
  • Relevant changesets are included (or are not required)

@tk-o tk-o requested a review from a team as a code owner May 19, 2026 08:01
Copilot AI review requested due to automatic review settings May 19, 2026 08:01
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 19, 2026

⚠️ No Changeset found

Latest commit: ed1bff2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
enskit-react-example.ensnode.io Ready Ready Preview, Comment May 19, 2026 8:15am
3 Skipped Deployments
Project Deployment Actions Updated (UTC)
admin.ensnode.io Skipped Skipped May 19, 2026 8:15am
ensnode.io Skipped Skipped May 19, 2026 8:15am
ensrainbow.io Skipped Skipped May 19, 2026 8:15am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

Review Change Stack

Warning

Rate limit exceeded

@tk-o has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 46 minutes and 33 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1192caaa-f24e-4d5c-9cb8-4a25396663ff

📥 Commits

Reviewing files that changed from the base of the PR and between 94505c4 and ed1bff2.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • apps/ensadmin/package.json
  • docs/ensnode.io/package.json
  • examples/enssdk-example/tsconfig.json
  • examples/omnigraph-graphql-example/tsconfig.json
📝 Walkthrough

Walkthrough

This PR updates workspace dependency versions across four package manifests in the monorepo. Dependencies previously pinned to a specific preview release version are now resolved to workspace:*, enabling local development to use the current workspace versions instead of pre-built packages.

Changes

Workspace dependency version updates

Layer / File(s) Summary
Update workspace dependencies across all manifests
apps/ensadmin/package.json, docs/ensnode.io/package.json, examples/enskit-react-example/package.json, examples/enssdk-example/package.json
Dependencies (@ensnode/ensnode-sdk, enssdk, enskit) switched from pinned 0.0.0-preview-fix-sha-89c022b-20260518142147 versions to workspace:* across all workspace packages.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🐰 Workspace links align, dependencies dance,
No more pinned previews by chance!
Monorepo flows smooth, each package in sync,
Local workspace magic with just a wink! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: switching to workspace:* versions to enable the release process.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request follows the required template with all essential sections completed: Summary, Why, Testing, and Pre-Review Checklist are all present and adequately filled out with relevant context.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/use-workspace-versions-to-enable-release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 19, 2026

Greptile Summary

Reverts @ensnode/ensnode-sdk and enssdk from pinned pre-release snapshot versions back to workspace:* in both apps/ensadmin and docs/ensnode.io, and regenerates the lockfile accordingly. The pinned snapshots were introduced in PR #2103 to make docs GQL examples work against the production v1.13 ENSNode instance, but they blocked the Changesets release workflow from merging; this PR restores workspace references so the release can proceed.

  • apps/ensadmin/package.json and docs/ensnode.io/package.json: swap two pinned snapshot specifiers for workspace:* each.
  • examples/enssdk-example/tsconfig.json and examples/omnigraph-graphql-example/tsconfig.json: remove DOM from lib and add "types": ["node"], correctly scoping these Node.js examples to server-side globals only.
  • pnpm-lock.yaml: updated consistently; the snapshot resolution entries for @ensnode/datasources and @ensnode/ensnode-sdk at the pinned version are removed.

Confidence Score: 5/5

Safe to merge — changes are limited to dependency specifier style and tsconfig scoping in example projects, with no logic changes.

All changes are mechanical: two package.json files swap pinned pre-release version strings for workspace:* references, two example tsconfig files drop a browser lib in favour of Node types, and the lockfile is regenerated consistently. The trade-off (docs GQL examples temporarily targeting local code rather than the v1.13 production API) is explicitly acknowledged by the author and tracked for a follow-up revert.

No files require special attention.

Important Files Changed

Filename Overview
apps/ensadmin/package.json Reverts @ensnode/ensnode-sdk and enssdk from pinned snapshot versions back to workspace:* references to unblock the release process
docs/ensnode.io/package.json Same revert to workspace:* for @ensnode/ensnode-sdk and enssdk; docs GraphQL examples will now target local workspace versions rather than the pinned v1.13 production snapshot
examples/enssdk-example/tsconfig.json Removes DOM lib and adds types:["node"] — appropriate for a Node.js example that doesn't need browser globals
examples/omnigraph-graphql-example/tsconfig.json Same tsconfig fix as enssdk-example: drops DOM lib, adds node types for a server-side example
pnpm-lock.yaml Lockfile regenerated consistently: pinned snapshot resolutions removed, workspace links added for ensadmin and ensnode.io docs

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Release PR / Changesets CI] -->|reads package.json specifiers| B{specifier type?}
    B -->|workspace:*| C[Resolved to local workspace package\nRelease can proceed ✅]
    B -->|pinned snapshot version| D[Changesets tries to update snapshot\nRelease PR blocked ❌]

    subgraph Before PR #2145
        D
    end

    subgraph After PR #2145
        C
    end

    C --> E[apps/ensadmin → workspace packages]
    C --> F[docs/ensnode.io → workspace packages]
Loading

Reviews (4): Last reviewed commit: "fix: include Node.js types for Node.js e..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates a handful of app/docs/example workspace package dependencies to use workspace:* instead of a pinned preview snapshot version, so that Changesets’ release PR automation can update versions cleanly without getting blocked by hard-coded snapshot strings.

Changes:

  • Replace pinned preview snapshot dependency versions with workspace:* in ensadmin, docs (@docs/ensnode), and two examples.
  • Update pnpm-lock.yaml importer entries accordingly and remove the now-unreferenced preview snapshot package/snapshot records.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pnpm-lock.yaml Converts affected importers to workspace:* + link: and removes unused preview snapshot entries.
examples/enssdk-example/package.json Switches enssdk dependency to workspace:*.
examples/enskit-react-example/package.json Switches enskit and enssdk dependencies to workspace:*.
docs/ensnode.io/package.json Switches @ensnode/ensnode-sdk and enssdk dependencies to workspace:*.
apps/ensadmin/package.json Switches @ensnode/ensnode-sdk and enssdk dependencies to workspace:*.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Otherwise, changests CI action auto-updates the pinned snapshot version: [example](b64fd63#diff-e84a22504342d0e481a7cf29fef59b1d5393caf086c46980f6d4a92adf5280ea).
@tk-o
Copy link
Copy Markdown
Member Author

tk-o commented May 19, 2026

@greptile revew

Copilot AI review requested due to automatic review settings May 19, 2026 08:15
@vercel vercel Bot temporarily deployed to Preview – admin.ensnode.io May 19, 2026 08:15 Inactive
@vercel vercel Bot temporarily deployed to Preview – ensrainbow.io May 19, 2026 08:15 Inactive
@vercel vercel Bot temporarily deployed to Preview – ensnode.io May 19, 2026 08:15 Inactive
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Copy link
Copy Markdown
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@tk-o tk-o merged commit 266fbe2 into main May 19, 2026
22 checks passed
@tk-o tk-o deleted the fix/use-workspace-versions-to-enable-release branch May 19, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants