Revert "fix: use workspace:* versions to enable release"#2147
Conversation
This reverts commit 4f53834.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR partially reverts PR #2145 by re-pinning
Confidence Score: 5/5Safe to merge — the change is limited to dependency version pinning with no runtime logic modifications. All five changed files are package manifests and a lock file. The workspace-to-pinned-version swap in ensadmin and docs is deliberate and explained in the PR description, and the lock file confirms the correct registry snapshots are in place for the May 19 preview build. No application code paths are touched. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph Before["Before (PR #2145 state)"]
A1[apps/ensadmin] -->|workspace:*| WS1[local packages/ensnode-sdk]
D1[docs/ensnode.io] -->|workspace:*| WS2[local packages/enssdk]
E1[examples] -->|0.0.0-preview-...-20260518142147| NPM1[npm registry - May 18 build]
end
subgraph After["After (this PR)"]
A2[apps/ensadmin] -->|0.0.0-preview-...-20260519094840| NPM2[npm registry - May 19 build]
D2[docs/ensnode.io] -->|0.0.0-preview-...-20260519094840| NPM2
E2[examples] -->|0.0.0-preview-...-20260519094840| NPM2
end
NPM2 -->|compatible with| PROD[ENSNode v1.14 Production API]
Reviews (2): Last reviewed commit: "Update pinned versions" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "@ensnode/datasources": "workspace:*", | ||
| "@ensnode/ensnode-sdk": "workspace:*", | ||
| "@ensnode/ensnode-sdk": "0.0.0-preview-fix-sha-89c022b-20260518142147", | ||
| "@ensnode/scalar-react": "workspace:*", | ||
| "enssdk": "workspace:*", | ||
| "enssdk": "0.0.0-preview-fix-sha-89c022b-20260518142147", |
There was a problem hiding this comment.
@ensnode/datasources in ensadmin
apps/ensadmin directly consumes @ensnode/datasources: workspace:* (the local development version) while the pinned @ensnode/ensnode-sdk@0.0.0-preview-fix-sha-89c022b-20260518142147 brings its own copy of @ensnode/datasources@0.0.0-preview-fix-sha-89c022b-20260518142147 as a bundled dependency (confirmed in the lock-file snapshot). The two copies will coexist in the dependency tree, and if any types from @ensnode/datasources flow across the ensadmin ↔ SDK boundary (e.g., as function arguments or return types), TypeScript may flag structural incompatibilities as the workspace copy diverges from the pinned copy over time. The docs site has no direct @ensnode/datasources dep and is unaffected. Was it intentional to keep the workspace version of @ensnode/datasources in ensadmin while pinning the SDK, rather than also pinning datasources directly?
There was a problem hiding this comment.
Pull request overview
This PR reverts prior workspace:* dependency references (introduced to unblock releases) back to pinned preview versions for ENSNode SDK and ENS SDK, primarily to keep docs’ interactive examples compatible with the current ENSNode production environment (v1.14).
Changes:
- Pin
@ensnode/ensnode-sdkandenssdkto0.0.0-preview-fix-sha-89c022b-20260518142147in ENSNode Docs. - Apply the same pinned versions to ENSAdmin.
- Update
pnpm-lock.yamlto reflect the pinned registry resolutions.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
docs/ensnode.io/package.json |
Pins SDK deps to a preview version to match production behavior for docs examples. |
apps/ensadmin/package.json |
Pins SDK deps to the same preview version (but leaves other related deps as workspace links). |
pnpm-lock.yaml |
Records the new pinned dependency graph and adds preview-package snapshots. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Use the following "preview" release outputs: https://github.com/namehash/ensnode/actions/runs/26089455699/job/76711088935
Lite PR
Tip: Review docs on the ENSNode PR process
Summary
workspace:*versions to enable release #2145 (commit 4f53834.)Why
v1.14). Themainversion of these GQL examples has changed in the ENSNodev1.14release.Testing
Notes for Reviewer (Optional)
Pre-Review Checklist (Blocking)