Skip to content

Enhance Renovate configuration#314

Merged
Ido David (ido-namely) merged 33 commits into
namely:masterfrom
ido-namely:master
Jul 19, 2022
Merged

Enhance Renovate configuration#314
Ido David (ido-namely) merged 33 commits into
namely:masterfrom
ido-namely:master

Conversation

@ido-namely
Copy link
Copy Markdown
Contributor

@ido-namely Ido David (ido-namely) commented Jul 10, 2022

  • Manage more dependencies with Renovate
  • Group gateway go package separately (we avoid upgrading this package atm because of a breaking change regarding fieldmasks)
  • Manage gateway go.mod template using Renovate's Go data source
  • Remove go.sum.template (no need for it since the go app is vendored anew in the generated docker file).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please make a small update to the readme discussing what Renovate is and how this project uses it? There is a link to it in the readme already but a few sentences to guide someone like me who may be interested to use the tooling you've set up but isn't quite sure where to get started (some typical commands for example) would be very helpful.

@ido-namely
Copy link
Copy Markdown
Contributor Author

Would you please make a small update to the readme discussing what Renovate is and how this project uses it? There is a link to it in the readme already but a few sentences to guide someone like me who may be interested to use the tooling you've set up but isn't quite sure where to get started (some typical commands for example) would be very helpful.

good call, will do.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread .github/README.md Outdated
Comment thread .github/README.md Outdated
Ido David (ido-namely) and others added 2 commits July 11, 2022 18:02
Co-authored-by: Steve Ognibene <steve.ognibene@namely.com>
Co-authored-by: Steve Ognibene <steve.ognibene@namely.com>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this LGTM, and the Renovate explanation helps give me some context, but I'm not yet enough of an expert to properly review all of this, so will (for now) just Comment.

Please let me know whether you want me to find some time to take a deeper dive in order to reach a go/no-go decision on this.

(Overall this seems like another great improvement to me.)

Comment thread .github/README.md
Comment thread README.md
@ido-namely Ido David (ido-namely) merged commit ddcb1d2 into namely:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants