Align the codebase with Effective Go conventions - #23
Merged
Conversation
Make chartStyles the single source of truth for style codes so chartOptionsFor and newSettingsModel can no longer disagree on the fallback for an unknown code: both now fall back to braille2 instead of chartOptionsFor's braille2 vs newSettingsModel's index-0 braille1, which used to render braille2, display braille1, and silently rewrite the config to braille1 on any unrelated settings change. Also: drawSettings truncates rows/help to terminal width like drawMenu/history do; renderBraille's loop locals no longer shadow the lo/hi bounds parameters; MockScreen in typing_renderer_test.go keeps one cell map instead of two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production code only — pairs with the test-quality PRs beneath it.