fix: the preset's grouping was narrower than the repos consuming it - #19
Merged
Conversation
The preset was lifted from eks-agent-platform's config, and that copy turned out to be the narrowest of the six rather than the canonical one. Adopting it as written would have regressed grouping in the four tenant repos, quietly, in the same change that was meant to stop them drifting. Two rules take the union instead. aws-sdk-js now also matches @smithy/*. Smithy is the runtime the AWS JS SDK is generated against; the four tenant repos already grouped them and eks-agent-platform did not. Split apart, a smithy bump lands as its own PR that cannot pass CI without the SDK bump that belongs with it. eslint-stack now also matches @eslint/* and eslint-config-*. Under flat config the @eslint/js core package moves with the plugins, and an upgrade that takes one without the others fails lint on its own. competitive-intelligence and slack-knowledge-bot had the @eslint/* half; digest-pipeline had both halves; eks-agent-platform had neither. Widening is the safe direction for a shared grouping rule: a pattern that matches nothing in a given repo costs nothing there, while a missing pattern produces a PR that cannot merge on its own.
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I got wrong
The preset was lifted from eks-agent-platform's config — and that copy turned out to be the narrowest of the six, not the canonical one. Adopting it as written would have regressed grouping in the four tenant repos, quietly, in the very change meant to stop them drifting.
Caught by diffing every consumer's rules against the preset before converting them, rather than assuming the bodies matched because the group names did.
Two rules take the union
aws-sdk-jsnow also matches@smithy/*. Smithy is the runtime the AWS JS SDK is generated against. All four tenant repos grouped them; eks-agent-platform did not. Split apart, a smithy bump lands as its own PR that cannot pass CI without the SDK bump that belongs with it.eslint-stacknow also matches@eslint/*andeslint-config-*. Under flat config the@eslint/jscore package moves with the plugins, and an upgrade taking one without the others fails lint on its own.@eslint/*eslint-config-*Why widening is the safe direction
For a shared grouping rule, a pattern that matches nothing in a given repo costs nothing there — while a missing pattern produces a PR that cannot merge on its own. Union, not intersection.
https://claude.ai/code/session_012iMnbboJuiUMSvu7n8oRhz