chore(deps): otel-collector 0.169.0, with the image following the chart - #195
Merged
Conversation
Three chart pins move 0.166.0 -> 0.169.0, and the three hand-set image tags come out. The tags are the point. Chart 0.166.0 declares appVersion 0.157.0 and all three values files pinned the image at 0.157.0, so the two agreed — but only by hand, and only for as long as nobody moved one. Chart 0.169.0 declares appVersion 0.158.0, so bumping the chart alone would have opened a divergence where none existed, in the direction that misleads: the chart ahead of the binary it names. Nothing would have reported it. Renovate reaches the chart pin through the argocd manager and does not read these values files at all — eks-gitops sets enabledManagers to argocd, gomod, custom.regex and github-actions, with no helm-values — so it moves the chart and cannot move the image. That is how the two spent a stretch a full release apart before. The chart renders `.Values.image.tag | default .Chart.AppVersion`, so deleting the tag makes the image a function of the pin rather than a second fact maintained beside it. Every future chart bump now carries its image with no second act. Two things checked rather than assumed. The rendered Deployment resolves to otel/opentelemetry-collector-contrib:0.158.0, so the default is reached and the values files are not overriding it somewhere else. And the contrib distro genuinely publishes the version numbers the appVersion tracks — that appVersion follows the core collector, and contrib is a different repository — confirmed against the registry for both 0.157.0 and 0.158.0. task validate passes: 109 addon×env combinations, 0 failed, and no 0.157.0 remains anywhere under addons/ or applicationsets/. kx mirrors this chart and follows in a paired change.
CI Results
All checks passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three chart pins move
0.166.0→0.169.0, and the three hand-set image tags come out.The tags are the point
"0.157.0"— agreed, by hand"0.157.0"— divergedThey agreed only because someone kept them agreeing. Bumping the chart alone would have opened a divergence where none existed, in the direction that misleads — the chart ahead of the binary it names.
Nothing would have reported it. Renovate reaches the chart pin through the
argocdmanager and does not read these values files:enabledManagersis["argocd", "gomod", "custom.regex", "github-actions"], nohelm-values. So it moves the chart and structurally cannot move the image. That is how the two spent a stretch a full release apart before.The fix is structural
The chart renders
.Values.image.tag | default .Chart.AppVersion(_pod.tpl:56), so deleting the tag makes the image a function of the pin rather than a second fact maintained beside it. Every future chart bump carries its image with no second act.Checked, not assumed
otel/opentelemetry-collector-contrib:0.158.0— so the default is actually reached and nothing else overrides it.0.157.0and0.158.0return HTTP 200 from the registry.task validate: 109 addon×env combinations, 0 failed. No0.157.0remains underaddons/orapplicationsets/.kx mirrors this chart and follows in a paired PR once this lands.