Add smart-money-pnl-leaderboard research command - #558
Conversation
pr-reviewer Summary for #725653d📝 1 finding Review completed. Please address the findings below. Findings by Severity
Review effort: 2/5 (Simple) SummaryThis PR is well-structured and follows established repo patterns throughout. The new Findings (1 low)
Lines 16–17 in the diff: import { buildPagination, parseSort } from './query-options.js';
export { buildPagination, parseSort };
import { resolveAddress, isEnsName } from './ens.js';The re-export is sandwiched between two Suggested fix: Move the Token usage: 1,362 input, 6,648 output, 1,003,870 cache read, 38,007 cache write | Usage Guide New pushes are reviewed automatically with a 10-minute cooldown between reviews. To request a review at any time, comment |
There was a problem hiding this comment.
Auto-approved
This PR was automatically approved because:
- Claude recommends approval
- Claude assessed this as a moderate effort change
- The effort level is within the auto-approval threshold of 2
- No high or critical issues were detected
- Review comment contains non-blocking feedback
If you have any concerns, please request a manual review.
…timeframe-days - schema.json: add filters, sort, page, and limit to the smart-money-pnl-leaderboard entry so agents reading 'nansen schema' can discover them - research.js: reject --timeframe-days values outside 1|7|30|90|180 with an INVALID_PARAMS error instead of forwarding them to the API Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Auto-approved
This PR was automatically approved because:
- Claude recommends approval
- Claude assessed this as a moderate effort change
- The effort level is within the auto-approval threshold of 2
- No high or critical issues were detected
- Review comment contains non-blocking feedback
If you have any concerns, please request a manual review.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Auto-approved
This PR was automatically approved because:
- Claude recommends approval
- Claude assessed this as a moderate effort change
- The effort level is within the auto-approval threshold of 2
- No high or critical issues were detected
- Review comment contains non-blocking feedback
If you have any concerns, please request a manual review.
cli.js and commands/research.js previously held separate copies with diverging semantics. Both now import one canonical implementation that validates --limit as a positive integer; cli.js re-exports for existing importers. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Auto-approved
This PR was automatically approved because:
- Claude recommends approval
- Claude assessed this as a moderate effort change
- The effort level is within the auto-approval threshold of 2
- No high or critical issues were detected
- Review comment contains non-blocking feedback
If you have any concerns, please request a manual review.
Resolve conflicts with chain-rank (#555), token-sectors (#556), and address-premium-labels (#557): keep all direct research subcommands in the subcommand set, help text, README, schema, and tests. cli.js and research.js share parseSort from src/query-options.js; research.js keeps its strict --page validation (main's tests require it) while the shared buildPagination keeps the lenient clamping the cli tests require. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
There was a problem hiding this comment.
Auto-approved
This PR was automatically approved because:
- Claude recommends approval
- Claude assessed this as a moderate effort change
- The effort level is within the auto-approval threshold of 2
- No high or critical issues were detected
- Review comment contains non-blocking feedback
If you have any concerns, please request a manual review.
Resolve conflicts with chain-rank (#555), token-sectors (#556), address-premium-labels (#557), and smart-money-pnl-leaderboard (#558): keep all direct research subcommands in the subcommand set, help text, README, schema, and tests. cli.js takes the shared query-options import from main and this branch's researchSub name for the dispatch call. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Resolve conflicts with chain-rank (#555), token-sectors (#556), address-premium-labels (#557), smart-money-pnl-leaderboard (#558), and position-intelligence (#559): keep all direct research subcommands in the subcommand set, help text, README, schema, and tests. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Summary
nansen research smart-money-pnl-leaderboardValidation
npm test -- src/__tests__/research.test.js src/__tests__/coverage.test.js— 88 passednpm test— 2,548 passed, 2 skippednpm run lintgit diff --check main...HEAD